From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D075B3C988F for ; Fri, 22 May 2026 10:15:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779444909; cv=none; b=Q9M39ulEHSFKIiH7mToaEKO8hU7iwXLA9CM4vhEQy8m405ON7PjQVSxwyunrilULeyDDhUimDY5AO7sZ0jR03SGPzFeIc+ugy6bgd+O7NW5TgyZvOWM1bDXlYpPxxQ3Hn+o/36d/DhhbHkKDrZ3sQfxz7EIS5Hpxis0jZHSEdpY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779444909; c=relaxed/simple; bh=/yxmDFswOx0w9wiVEewfyX6IVYQi4wAMBnDeD1IdRwQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PRAoJMyLGiFAKpMPSPa777ouoFf9bd581VzdX2I/CQvZkAKivXgQgxi+ADm2kzlhJOQLfJZ0hTROSfGPqLaMRfRqXB96h/BbHcGQoi+yzbnjywmsJ2w0FFEPppsv8aJlRRVFERSgi/dCGRd8tLVYfRmpYgD1ivNvSgGChTiL940= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eOSPfDl2; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eOSPfDl2" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-48fe26a177cso53806315e9.1 for ; Fri, 22 May 2026 03:15:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779444906; x=1780049706; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yOAQCrLo3DVebScmr4gEaN7TLeXl7WWHrX8xDm80OJE=; b=eOSPfDl21QMVMgB3UaEPPQB/KvE3OGDey6qmYlv3p6eS1qzgwUBzFgzV/5PIMNWKgi BYhYeQItrLRI+ebhcv19R8dibcZabnkYKr5xZ56cdlk4vVFf7ELAVMFyCyEspmrqh+tH FCL8VDMUTaBc36zHp8VlkrLy1EAd7i9eOrgxNpputPS5tdHlIc/xijIDv6058dEfvBLR cQic8ydSWOZD965k001W6QaRRvBm6ZaAmdwEoVVTU1zXYMdgkW3gTfCqjq0m+Of5C4CI VQAYL5Jw52ntBS/D8s1iVeTyaHnwLzGXa648C3nyp5Q7SoIIJequLecuPWCQh4RpWIpY psRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779444906; x=1780049706; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yOAQCrLo3DVebScmr4gEaN7TLeXl7WWHrX8xDm80OJE=; b=MgsQCQzUh8WSXBVDG1p/8Llvc2Li/L2B8IUYTzWUGKslgJralqdTScVTrO7nG6huJb KFL2/h85jqiJ74jc0JRLM8F9mXqmapy0qs+ah1XpWIVsJfbaeDNvwkVjQSGeH1rGTK6I CQyWmuIqKPJhW3UkMcaBhxwuQEjGcobu2aNc4QaTpdHRnsKmVl7aPgXXKCf9kh4TkIw4 5Jbi47nZH79AOl8EN1edcpxm6hY7iSgK8qWNiqGMsSbjfTLgxevm7h6CFc4Q4Un9+COT oYE2WK8nvdTCOeFK2AY0DhUfTG2CtiUW4MlWBptmGvYD4GqRKntC/ZDVZL2xwtb4fg/d 4olg== X-Forwarded-Encrypted: i=1; AFNElJ/jmPYq9B0Mg6zw9nZa9H7b/3/cGa/vP6aRWOticero9lF4J8DbcXI1BcK6rfBhQNPbiSxbqykXr62n@vger.kernel.org X-Gm-Message-State: AOJu0YzY4w/5vKfN5q8J1qDlkW6tZx89xullFoFNe6FClRC3+MlU4OQg S4R16toXkvqQPBbR2NwuW72kFmCyUIEpQfSoDGRYwgtHV1wAYMb9BGbA X-Gm-Gg: Acq92OEzQ8wyevkXwR4pHiMYpQY6Jit1dWz5gJxt1hIEKDDFk07UfLUJCFYBSPHeSiM 52T3ZNLgaRs1m0lYHxZhYcl4QlsdhmBg0TM/DH82hountxwefJMdvc1c9DijAiwo3tyT3aGX+ys stFXEDXJUwmrU3892VAVfhBgJ5BFYiZrTP3777hleh/ZcQvJJc7jat1GgYDhUvtVu8KCLHhIDPb Av/LHQC5/KKBkvozBd0HtTW1VFXKJOXwIIcPh4qoyx0S2tENviAs4G+ABtZjiTjSLM5XcnMfEOm lZinbqRViIZ1o3COpDtCIBzGVITTrswZ8U2sgz8wMBO4QsjU/MEEiowVIO9xlKFFXvAsdI2Ksel RjvYHppztcQMAlTqNq982xaKkK5X+HGzCwbw78aW1BspPGOXlKUS4HE231Ff2VC7yaofsMh1Ba1 2xUmSSToE3oqybrniAtoY7gXI6mMU8dNucgA5x3jnkTEqJdoyCnbOFXG1Tsb5lFa37mGzi5wany 4gHjO85Ji8WTw== X-Received: by 2002:a05:600c:4510:b0:48f:e230:72fc with SMTP id 5b1f17b1804b1-490428ee268mr34911935e9.33.1779444905920; Fri, 22 May 2026 03:15:05 -0700 (PDT) Received: from orome (p200300e41f291e00f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f29:1e00:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4904561f2dfsm29695065e9.12.2026.05.22.03.15.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 03:15:02 -0700 (PDT) Date: Fri, 22 May 2026 12:15:00 +0200 From: Thierry Reding To: Akhil R Cc: Vinod Koul , Frank Li , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Hunter , Laxman Dewangan , Philipp Zabel , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Frank Li Subject: Re: [PATCH v6 05/10] dmaengine: tegra: Use struct for register offsets Message-ID: References: <20260331102303.33181-1-akhilrajeev@nvidia.com> <20260331102303.33181-6-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="imzmnmclq2alqm7o" Content-Disposition: inline In-Reply-To: <20260331102303.33181-6-akhilrajeev@nvidia.com> --imzmnmclq2alqm7o Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v6 05/10] dmaengine: tegra: Use struct for register offsets MIME-Version: 1.0 On Tue, Mar 31, 2026 at 03:52:58PM +0530, Akhil R wrote: [...] > diff --git a/drivers/dma/tegra186-gpc-dma.c b/drivers/dma/tegra186-gpc-dma.c [...] > @@ -181,18 +149,24 @@ struct tegra_dma_chip_data { > unsigned int nr_channels; > unsigned int channel_reg_size; > unsigned int max_dma_count; > + const struct tegra_dma_channel_regs *channel_regs; Odd. I would've thought you'd have to predeclare the structure, but if this builds fine, I suppose it's okay this way, too: Acked-by: Thierry Reding --imzmnmclq2alqm7o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmoQLKQACgkQ3SOs138+ s6Fm9A//TpPiDRyGRX5S+DREIyuLzv0q+Fts53fWV69V2cKAdllYUgvBAaGN6kiu 0x7UYLj+83kly4h8EYq3tFWWbk9CZneS/6dURNSzUlSzo5Cdl/zzXfeXeJriWTHP mgdbVh3oFdl/l0ITQPFG/dvFoEB30eST3qWCPImXLl3upt2IuHYoGPUuwlZSwOWs TIKRQp84R096p6Y/axdNeevLjJ3x24AF6OvcdF/Bp0hUhHdBVUN29vQ3BwUVOIeO RYeT0uF8Ns3TpiQSZbvKROOZZRoJYm4jiEu0dLUPxr7TBOtzNxZrmRYcKFc+uPvq /gqfMZ6jQM72h0yLBw5SEU09XHh1uTzkbnemIjA8VHYaIBofhSFPxysZDdMNY1nf YyaMBPtDX+cj7wEjcFAp8r+7X9vYd+eojs5a2j1j6hj2ZGncDVj6ES6p9NoNUKIe YGBTKKM1J1CDtUa5Ty1IMcpaMjV/o3Xe89mmNAJ85w0S+ga0c5lP0DDR418jRIpP lJOsuBG1ulxLVB74o6UX3HAKPblhpe9lawyH/Wx9UvwIYvtyH/CmTx05VgJeA/p8 wgVchLEGPT222TJmmH3SAWRswoVc72wxxoAzn4URbRTXATh7lO9yEpKSG7TefOhV iroH1+Ob5vi8gkoLBKz5uyA4UCCpGxVi2um4oBXXf5nennrswY8= =Kkfg -----END PGP SIGNATURE----- --imzmnmclq2alqm7o--