From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE4113859EF for ; Wed, 3 Jun 2026 09:24:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780478673; cv=none; b=QpEbry6t45edWBry/FAfJmoM2YWx6cBbcin8YEnY25eaaT5FPTBQHabXNO/1vHMwCtGxWZexMSHe3LzhsDVfUigqZp69BIzRL+DkQZ2Bb16nNmjcvUArdAZy1Ma7WYNUI+9dlG+kcqkCYwrvZA6zUD3j61+d2Qc8+gWCMRcouIQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780478673; c=relaxed/simple; bh=tQj2iyJK/ty6qWuD2nWo27J7s0BD+yJmE/SnLkDfTOw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fpf4tqP66/Z6mMjTk/4nAxB4CRJ8NNO2uliqpd1B4v9ufBCd/tWvEpwAOFZS6bZSji3rtkD1UnDhU45zpfFVcozxrJNQk/kB6D0rXTDlTRao47/ZM963GPmKKlNM5QMWbJNWVIrrWwpS+kvOciBLaSNfaqsXu2r+eFsa40ujnbU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GsQBXovb; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GsQBXovb" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-36ab8816a35so6178107a91.1 for ; Wed, 03 Jun 2026 02:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780478672; x=1781083472; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+evDZWLT5KzG1ZaMkX3r55/gKlKfN0VfS6IPwHPUrVw=; b=GsQBXovbGdARAw1pgk5FGKHkDydrlbGmG20n/+U2X+/Y8+dR4lbFZW7mVz/y6AuSWZ GB2JqEomZ5yLcUy0prQcJJuvpOYC+ZNvuIsGXdtKglMYZA0urAW2SgVx1DZhkpmyF+Es NCOsUw0cY2OCPHEN1PFvow8H5aSfghLPsBnv0yAuSi83roV0WKy/wakhEPQKzcgymCSK fmKCWqX9DJTfHmHzbn5ctrPwHqynEqd1BgUXu1qqzpTwSX2kA3qCIiQnHP+kQeagw3Bi nJoCJEbFgWb+WiCQoIzg5mO8ueusnyvuZrF2vlK0tc2cWwyyLXuvai/PSa9h/Pfsf9ZF tC/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780478672; x=1781083472; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+evDZWLT5KzG1ZaMkX3r55/gKlKfN0VfS6IPwHPUrVw=; b=onGOycTb04JyTXxPYo8CbSufGPspHLCfmIOr4Ixnns3ZCw967VGkwDJFp9Ssindqdo MXZoJi6zgcrA1A8b6u6nob+Noi3DU3DlgC7JOWo+7xamrEU4dP2AZSrjtTeUIWkzUqHq mEDzNiI5YOX6ZLiDeBKYPL3i/iGVIA8VQf7zba1G+KR5BLNVBc2cq0X2Xlr0Qi3N5zUY 5r8KMP/OOrqpmg63fFqYWK/UsPggPinh81Ajrh+SDukarA0zkAZBPMYtYAwuYt7zcPox IaHO987bhBRl1Eqf37Jz2hKDoXL3orRZrT03lN9TVXp/NURAo/N8Q3Jx4mHSMowOuwFX kxYw== X-Forwarded-Encrypted: i=1; AFNElJ91PEW/XJklcvEd71V4U7nU4fPyxr+FeUMuz2HAKDt2KGTBSIhR+miYNiF7PmYXtIvLe+6C38+Y5+DO@vger.kernel.org X-Gm-Message-State: AOJu0Yy2rK8UdPqi9JFTP6CJJxH57bInnnnQaAdENAKHV5y2ET6tnL4m 2MQwZXvTgV50IJVu1ASRGDB2MKlh84mGO4naMWljoiXSYd08HPYI3AKE8yr2mtkq X-Gm-Gg: Acq92OEfMSJTidOASBuqY0lOT+pvo4s2pVn0qmJAdGf1cm9WYVbuE6ZP1XH42Fo/DEj oHi3jMWz3O8otkW7svchM2pjSt4ZmiNXY8Vc4T7/+B77RMcvEzBoX0lOS/eyiYNlrb3YbeGJSTr y1bYkX/Akv7NHrQG+wopGfwDAUfLKUNJwF9JNpQzHXUAIwLM/Wq/4R3T6USBYZN8a49dGxiPRRJ Hgsuqy+pKYJ1VADohmdfV1rML9KNkqdiaPgBsUsXgP7w7RsouGZ49zGjA4uFjuBH73eRcc2WEBr YZ599HULvcfFH0H4eN97dwRwGWd96KTCmRPBTONvrLjpQ5OWd3zu8Ojmq46s/fX4zJTs26nrMsJ lYNyFNxFmBD85InDuJpsHkDOhSW12+HqHT+BxucJ1pbQ+/EzGLQWRzb2OFS73nBrcxacLUOM8kt /gHk5tOHvobMJ8QFVOlq+1zju1O0Oq4f4p/A== X-Received: by 2002:a17:90b:2d8d:b0:36b:e8b9:46a4 with SMTP id 98e67ed59e1d1-36e32285cf3mr2634132a91.14.1780478671804; Wed, 03 Jun 2026 02:24:31 -0700 (PDT) Received: from localhost ([2001:19f0:8001:1b2d:5400:5ff:fefa:a95d]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36e0a276ef2sm2484283a91.11.2026.06.03.02.24.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 02:24:30 -0700 (PDT) Date: Wed, 3 Jun 2026 17:24:10 +0800 From: Inochi Amaoto To: Rob Herring , Inochi Amaoto Cc: sashiko-reviews@lists.linux.dev, devicetree@vger.kernel.org, conor+dt@kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v2 4/5] dt-bindings: PCI: spacemit: Introduce Spacemit K3 PCIe host controller Message-ID: References: <20260517014841.254085-5-inochiama@gmail.com> <20260517024848.4F346C19425@smtp.kernel.org> <20260601224224.GA116470-robh@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260601224224.GA116470-robh@kernel.org> On Mon, Jun 01, 2026 at 05:42:24PM -0500, Rob Herring wrote: > On Sun, May 17, 2026 at 12:38:39PM +0800, Inochi Amaoto wrote: > > On Sun, May 17, 2026 at 02:48:47AM +0000, sashiko-bot@kernel.org wrote: > > > Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider: > > > - [Medium] The binding completely omits the `interrupts` and `interrupt-names` properties for the host controller. > > > - [Medium] The schema omits standard legacy INTx interrupt routing properties (`#interrupt-cells`, `interrupt-map`, `interrupt-map-mask`). > > > - [Low] The `phy-names` property lacks an `items` definition to restrict valid string values. > > > -- > > > > > > commit 7b8ba34456e71d6a9cf1028caa5504d64e8f58ba > > > Author: Inochi Amaoto > > > > > > dt-bindings: PCI: spacemit: Introduce Spacemit K3 PCIe host controller > > > > > > This commit adds device tree binding support for the PCIe controller on the > > > SpacemiT K3 SoC. The controller is based on the Synopsys DesignWare PCIe IP > > > with some extra link and reset state control. > > > > > > > diff --git a/Documentation/devicetree/bindings/pci/spacemit,k3-pcie-host.yaml b/Documentation/devicetree/bindings/pci/spacemit,k3-pcie-host.yaml > > > > new file mode 100644 > > > > index 0000000000000..46147a37a9ce6 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/pci/spacemit,k3-pcie-host.yaml > > > [ ... ] > > > > + reset-names: > > > > + items: > > > > + - const: dbi > > > > + - const: mstr > > > > + - const: slv > > > > + > > > > + msi-parent: true > > > > + > > > > > > The driver implementation reads and clears interrupt status registers for > > > host-level events, and references registers for receiving INTx events from > > > downstream devices. > > > > > > Should this binding include interrupts and interrupt-names properties to > > > document the host's interrupt routing? > > > > > > Additionally, should standard legacy INTx interrupt routing properties like > > > #interrupt-cells, interrupt-map, and interrupt-map-mask be included in the > > > schema and example to support downstream devices that do not use MSI? > > > > > > > The driver just does the interrupt cleanup as it requires, and no > > additional interrupt is needed > > Unless there are no interrupts and only MSIs are supported, then you > need to define 'interrupts' property at least. The common schema only > defines all possible names, but not which ones are used and the order. > > Rob Yes, currently there is no interrupts that should be enabled in Linux, and only MSI is supported without INTx. So I think it is fine to removed the interrupt properity. Regards, Inochi