Re: [PATCH RFC v5 16/18] ACPI: RISC-V: Parse RISC-V Quality of Service Controller (RQSC) table

[Drew Fustini <fustini@kernel.org>]

On Mon, May 25, 2026 at 01:53:09PM +0530, Sunil V L wrote:
> > +               if (info.mcid_count > CBQRI_MAX_MCID) {
> > +                       pr_warn("controller at %pa: mcid_count %u exceeds CBQRI_MAX_MCID %u, skipping\n",
> > +                               &info.addr, info.mcid_count, CBQRI_MAX_MCID);
> > +                       continue;
> > +               }
> > +
> Do you also want to add a check for the statement in the spec "At
> least one of RCID Count or MCID Count must be non-zero." ?

Good idea, I'll add a skip with pr_warn when both are zero.

> > +/* RQSC v0.9.2 Table 4: Resource Type values for acpi_rqsc_resource.type. */
> > +#define ACPI_RQSC_RESOURCE_TYPE_CACHE  0
> > +#define ACPI_RQSC_RESOURCE_TYPE_MEMORY 1
> > +
> > +/* RQSC v0.9.2 Table 4: Resource ID Type values for .id_type. */
> > +#define ACPI_RQSC_RESOURCE_ID_TYPE_PROCESSOR_CACHE     0
> > +#define ACPI_RQSC_RESOURCE_ID_TYPE_MEMORY_RANGE                1
> > +
> Memory-Side Cache, ACPI, PCI devices missing?

I'll add the constants for the future.

Thanks,
Drew