From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CD5A3A0E80; Mon, 15 Jun 2026 06:37:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781505451; cv=none; b=k3P2huGgOZBUihihMfOyKfsNAptgbKF+y1gZyG4+Vde6YUjSN2G8rKwkWFvwwG+kLTVrfASOZ3GpYCJO0RdVy38DVk7UO9OZGMym5cmnY6QeL0EtxEzRyumKbjDv7k9FmLcRw1kO+9OiLDVfUg2IAyj1+Eg/GJlXAV9BwnM+LrQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781505451; c=relaxed/simple; bh=xYhec2l2zy7ltRZnfYBjNGcFte6NZlmFwPRyNJOyiaE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I4sNChW2fobciC8BujIxihRTexnGXBI9Z86jOoJsmy75/UnLNrsZI9tuy7A2D2g463VmvExzBvCqxfveaAVtTYi7ugZS6idIJuaZL+4vR6lEVBilcdcheDYd/AoZ3WGVWBQdHZhorU5oMYz39DEF+8ov0umQwn3ftam2xsJsV4w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KWVdxXcM; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KWVdxXcM" Received: by smtp.kernel.org (Postfix) with UTF8SMTPSA id 539C21F000E9; Mon, 15 Jun 2026 06:37:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781505451; bh=wYvlTdTkI8iTFk+/aWNvdop1BELaOWjR9XgqorfHy0o=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=KWVdxXcMy5KN4BO2w3B22IRJrWNfqThxDyUC0W8HUkClZuh2P9N9iWaBPIZoBlaRt boUKjMI3L5d9spGYBtbMPEIGbNBJE5swnZVzIYy/27dOv9HGs+M/7a9cxebTCsvk84 vJ9Mwq2PqNQ3q3zmKQFAZekSsQ9/Fa4iQc7mAkms/aSStQtJdzXrkjCAj5lgJmiE1r EwMu4BrlqhYYlxZy0YuDxkTVikIdxwekAwj/Us+diEjiAc7i380cKyY0CWrfDUwOvS RliT5chIFPkzKkYZV36iTCzJJR1EB2htPdsDeH4dYYCDEen4Mb6GQwL92UvXY+XUak vNF6so87QfGjw== Date: Mon, 15 Jun 2026 08:37:28 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Julian Braha Cc: Andrea della Porta , linux-pwm@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Naushir Patuck , Stanimir Varbanov , mbrugger@suse.com Subject: Re: [PATCH v5 2/3] pwm: rp1: Add RP1 PWM controller driver Message-ID: References: <0b6a7f41-b753-48dc-b46e-77aaf0e999f4@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ajhov2qxsz3lss5g" Content-Disposition: inline In-Reply-To: <0b6a7f41-b753-48dc-b46e-77aaf0e999f4@gmail.com> --ajhov2qxsz3lss5g Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v5 2/3] pwm: rp1: Add RP1 PWM controller driver MIME-Version: 1.0 On Sat, Jun 13, 2026 at 01:27:49PM +0100, Julian Braha wrote: > On 6/12/26 15:01, Andrea della Porta wrote: >=20 > > +config PWM_RASPBERRYPI_RP1 > > + tristate "RP1 PWM support" > > + depends on MISC_RP1 || COMPILE_TEST > > + depends on HAS_IOMEM > > + select REGMAP_MMIO > > + select MFD_SYSCON > > + help > > + PWM framework driver for Raspberry Pi RP1 controller. > > + >=20 > Hi Andrea, >=20 > Selecting REGMAP_MMIO is unnecessary here since you're already selecting > MFD_SYSCON. IMHO selecting REGMAP_MMIO explicitly here is fine because at least to me it's not obvious that MFD_SYSCON enforces REGMAP_MMIO. Best regards Uwe --ajhov2qxsz3lss5g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmovnaUACgkQj4D7WH0S /k6rsQf/UOXqKwIUO7qhgK9i5TY4JtULpUGRl6MSYUIchZKFq4oJExnI1G1PeqVe B5QU11I7UGYCjLgU8TBxtxpajjDFLxl+9c9a+AgJNftMMlSXV4ow8aaE9f3ejLFd 71RW8KxSTWSmXioUKYFklPhx6PaKSaob6D3tE78UBsm95+m8RNQPGFNjus73flHZ RYJU+Kw9oFjKhrYWD628kCEED5GjMK6xvExvq33NP6RNi8nFvsLlcB0kbC/89esk SWE2CiR/4hGygS1KtKNMA9WjLxxVSCJWeWPv024Fb06m83lBiOJfImYHZyFt2PPQ hmyOo+L9FLZ2rshpaiIaqAZgYZarhw== =s2AI -----END PGP SIGNATURE----- --ajhov2qxsz3lss5g--