Devicetree
 help / color / mirror / Atom feed
From: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Marcelo Schmitt <marcelo.schmitt@analog.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, jic23@kernel.org,
	nuno.sa@analog.com, Michael.Hennerich@analog.com,
	dlechner@baylibre.com, andy@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	pop.ioan-daniel@analog.com
Subject: Re: [PATCH v2 0/4] iio: adc: Add support for LTC2378 and similar ADCs
Date: Wed, 3 Jun 2026 11:11:06 -0300	[thread overview]
Message-ID: <aiA1-tAnRjYQu2EO@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <ah_e4ovBsXQ-BVcw@ashevche-desk.local>

On 06/03, Andy Shevchenko wrote:
> On Thu, May 28, 2026 at 12:02:53PM -0300, Marcelo Schmitt wrote:
> > This patch series adds support for LTC2378 and similar low noise, low power,
> > high speed, successive approximation register (SAR) ADCs. These ADCs are similar
> > among each other, varying mainly on the amount of precision bits, maximum sample
> > rate, and input configuration (either fully differential or pseudo-differential).
> > 
> > The initial support patch enables single-shot sample read with a GPIO connected
> > to the CNV pin.
> > 
> > The second support patch enables high-speed data captures with SPI offloading.
> > The setup is similar to AD4030, with a specialized PWM generator being used both
> > for SPI offload triggering and conversion start signaling.
> > 
> > The last support patch enables running buffered data captures without SPI offloading.
> > 
> > Some structures and variables are introduced earlier to reduce diff in latter patches.
> > 
> > The initial version of the LTC2378 driver was developed by Ioan-Daniel. Though,
> > despite of the many changes I made to the code, I've kept him as module author
> > to provide credit for his work.
> 
> No datasheet link, no explanation why the brand new driver is needed.
> No need to resend, just answer the above questions.

Hello Andy, thank you for having a look at this set.

In short, this new driver is needed for supporting LTC2378-20 and similar ADCs.
Even though these parts are somewhat similar to AD4000, the available HDL for
high speed sample rate mode is different and the wiring configuration is also
different. Because of that, I think cramming LTC2378 support into AD4000 driver
might not be a good idea. I'll add a note about that in v3 together with
datasheet links.

There are some good points that Jonathan and sashiko raised in v2 and I'm still
working out a solution for some of them. Will share a v3 after tackling out the
remaining issues.

Thanks,
Marcelo

> 
> > Link to v1: https://lore.kernel.org/linux-iio/cover.1779117444.git.marcelo.schmitt1@gmail.com/
> 
> -- 
> With Best Regards,
> Andy Shevchenko

      reply	other threads:[~2026-06-03 14:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-28 15:02 [PATCH v2 0/4] iio: adc: Add support for LTC2378 and similar ADCs Marcelo Schmitt
2026-05-28 15:03 ` [PATCH v2 1/4] dt-bindings: iio: adc: Add ltc2378 Marcelo Schmitt
2026-05-28 16:55   ` Conor Dooley
2026-05-28 15:03 ` [PATCH v2 2/4] iio: adc: ltc2378: Add support for LTC2378-20 and similar ADCs Marcelo Schmitt
2026-05-28 15:51   ` sashiko-bot
2026-05-29 10:02   ` Jonathan Cameron
2026-05-29 12:37     ` Marcelo Schmitt
2026-05-29 17:31       ` Jonathan Cameron
2026-05-28 15:04 ` [PATCH v2 3/4] iio: adc: ltc2378: Enable high-speed data capture Marcelo Schmitt
2026-05-28 16:39   ` sashiko-bot
2026-05-29 10:29   ` Jonathan Cameron
2026-05-28 15:04 ` [PATCH v2 4/4] iio: adc: ltc2378: Enable triggered buffer " Marcelo Schmitt
2026-05-28 17:21   ` sashiko-bot
2026-05-29 10:30   ` Jonathan Cameron
2026-06-03  7:59 ` [PATCH v2 0/4] iio: adc: Add support for LTC2378 and similar ADCs Andy Shevchenko
2026-06-03 14:11   ` Marcelo Schmitt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiA1-tAnRjYQu2EO@debian-BULLSEYE-live-builder-AMD64 \
    --to=marcelo.schmitt1@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=pop.ioan-daniel@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox