From: Akash Sukhavasi <akash.sukhavasi@gmail.com>
To: sashiko-reviews@lists.linux.dev
Cc: dmitry.torokhov@gmail.com, robh@kernel.org,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
conor+dt@kernel.org
Subject: Re: [PATCH 4/4] dt-bindings: input: remove obsolete matrix-keymap.txt
Date: Wed, 3 Jun 2026 15:15:00 -0500 [thread overview]
Message-ID: <aiCKBXqvOmQ8gC_t@gmail.com> (raw)
In-Reply-To: <20260530052311.271791F00893@smtp.kernel.org>
On Sat, May 30, 2026 at 05:23:10AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The commit message inaccurately claims that 'Eight files still reference matrix-keymap.txt', when only 6 files actually do.
> This commit removes the obsolete matrix-keymap.txt stub and updates all
> remaining references across the input and mfd binding documentation to
> point directly to the matrix-keymap.yaml schema.
>
> > Eight files still reference matrix-keymap.txt, forcing readers
> > through an extra hop to reach the .yaml. The stub has not been
> > touched since June 2020. Update all references across input and mfd
> > binding documentation to point directly to matrix-keymap.yaml and
> > remove the stub.
>
> [Severity: Low]
> This isn't a bug, but the commit message states that eight files still
> reference the text file. Looking at the patch, there are eight total
> references updated, but they are spread across only six files since
> tc3589x.txt contains three of those references.
Yup, my bad. I counted eight and wrote that, should've said eight
references across six files. Sending v2.
> Sashiko AI review · https://sashiko.dev/#/patchset/20260529052246.4934-1-akash.sukhavasi@gmail.com?part=4
--
Thanks,
Akash
prev parent reply other threads:[~2026-06-03 20:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 5:22 [PATCH 0/4] dt-bindings: remove redundant .txt redirect stubs Akash Sukhavasi
2026-05-29 5:22 ` [PATCH 1/4] dt-bindings: net: remove obsolete mdio.txt Akash Sukhavasi
2026-05-29 5:22 ` [PATCH 2/4] dt-bindings: media: remove obsolete rc.txt Akash Sukhavasi
2026-05-29 5:22 ` [PATCH 3/4] dt-bindings: net: dsa: remove obsolete dsa.txt Akash Sukhavasi
2026-05-29 5:22 ` [PATCH 4/4] dt-bindings: input: remove obsolete matrix-keymap.txt Akash Sukhavasi
2026-05-30 5:23 ` sashiko-bot
2026-06-03 20:15 ` Akash Sukhavasi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiCKBXqvOmQ8gC_t@gmail.com \
--to=akash.sukhavasi@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox