From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Kim Seer Paller <kimseer.paller@analog.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@analog.com, devicetree@vger.kernel.org
Subject: Re: [PATCH 0/3] iio: dac: ad3530r: Add support for AD3532R/AD3532
Date: Thu, 4 Jun 2026 12:36:58 +0300 [thread overview]
Message-ID: <aiFHOj0dVv2fasD1@ashevche-desk.local> (raw)
In-Reply-To: <20260604-iio-ad3532r-support-v1-0-c3552f9031de@analog.com>
On Thu, Jun 04, 2026 at 03:13:42PM +0800, Kim Seer Paller wrote:
> This series adds support for the AD3532R/AD3532, a 16-channel, 16-bit
> voltage output DAC, to the existing ad3530r driver.
>
> The AD3532R uses a dual-bank register architecture (bank 0 at 0x1000
> for channels 0-7, bank 1 at 0x3000 for channels 8-15), which required
> refactoring the register access paths. A table-driven register bank
> approach is introduced where per-chip register address arrays in
> chip_info are iterated by helper functions, replacing the single-register
> setup calls for existing variants and scaling naturally to the AD3532R's
> dual-bank layout.
>
> The series also adds AD3532R-specific powerdown modes (1kohm_to_gnd,
> 10kohm_to_gnd, three_state) and a new ABI entry for the 10kohm_to_gnd
> powerdown mode.
This cover letter misses two required things:
- why do we need a brand new driver (provide an explanation)?
- where to get the datasheet (provide a link)?
Just reply to this email and if new version is required do not forget
to add it to the cover letter.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-06-04 9:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 7:13 [PATCH 0/3] iio: dac: ad3530r: Add support for AD3532R/AD3532 Kim Seer Paller
2026-06-04 7:13 ` [PATCH 1/3] iio: ABI: add DAC 10kohm_to_gnd powerdown mode Kim Seer Paller
2026-06-04 7:13 ` [PATCH 2/3] dt-bindings: iio: dac: add support for AD3532R/AD3532 Kim Seer Paller
2026-06-04 17:01 ` Conor Dooley
2026-06-04 7:13 ` [PATCH 3/3] iio: dac: ad3530r: Add " Kim Seer Paller
2026-06-05 13:24 ` Jonathan Cameron
2026-06-11 7:04 ` Paller, Kim Seer
2026-06-11 12:29 ` Nuno Sá
2026-06-11 18:48 ` Andy Shevchenko
2026-06-04 9:36 ` Andy Shevchenko [this message]
2026-06-04 10:29 ` [PATCH 0/3] " Paller, Kim Seer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiFHOj0dVv2fasD1@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kimseer.paller@analog.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox