From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 457B13955DC; Fri, 5 Jun 2026 18:02:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780682544; cv=none; b=G+ipzHomkIC7+6PCEO3FKRNCOauQNgxf5tn4QyPfsMAVfUmm8EIVUA9rC3qv7vT9Q7xeY+qHMd8vIEPgP3ykGYfyeMadUeLm3OGGvPMuaCpgkneEvmAgL7ToQGVKXINuT8fO77N+g95/unJPB41vY2cMOEkueU1P/g5nz/9c3yw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780682544; c=relaxed/simple; bh=C8o+Feus096h0Uz102T1DCDSL3wzEZgY/+zUm2CvINc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iPSjdjbbXEMV4Ib7K5MQ87vaUivSDCYSF5XZm0+mJxXW2gaUfqyhiVcMXJxRhlduos3/dRuiRcI8M/2mSZEwYO1PmxeNKtx2f5Ci0RKBCNtQ+Fc27YH/4WJ7jR1zJkCohKSdAOPVam+2UDLMgcwCmJJH+NK3RiGC7zmoAEu/4ZQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=c7gO/Dt9; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="c7gO/Dt9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780682543; x=1812218543; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=C8o+Feus096h0Uz102T1DCDSL3wzEZgY/+zUm2CvINc=; b=c7gO/Dt9cyGDvBUNC+no4CbD3WpyQ64vGPkvuASf/mdamMaN4h5AQARX ZeeKNgcLh9J14TszOL2qTG6x/GdoEKss1s/0HlpE8bNn8EvD42ujGr7Q7 hGwVBKKYrpY4+ay10rrjYSw764E1VoBGgqjpzJzMlZVS+Mc7HosvgoAKA nYi4uMd0FZzxTuLnF14P0V+cw2NjH8yE4vv1vzYtncUohj660SdJZCaHb JN9ml4LRMUs9rV1gqbtCqgWusph5FLK/wrcDUxKt9sDqMac/FEuzm45Z5 OlstRcJuVZ0l9YKzT+IaCqe6OH53Gl302/lrLDHbTpttX5xe7pcOLWDKT w==; X-CSE-ConnectionGUID: 3jUTfQg1Rsalf+TAOX8Fgw== X-CSE-MsgGUID: n77aAdOITRisyJiGhCXWZQ== X-IronPort-AV: E=McAfee;i="6800,10657,11808"; a="91834723" X-IronPort-AV: E=Sophos;i="6.24,189,1774335600"; d="scan'208";a="91834723" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2026 11:02:22 -0700 X-CSE-ConnectionGUID: 82ostdTaTBWKpezxDiFWOA== X-CSE-MsgGUID: 9LFON0bcQHuG2jIdBXDWQA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,189,1774335600"; d="scan'208";a="249242284" Received: from ettammin-mobl2.ger.corp.intel.com (HELO localhost) ([10.245.245.178]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2026 11:02:18 -0700 Date: Fri, 5 Jun 2026 21:02:15 +0300 From: Andy Shevchenko To: Jonathan Cameron Cc: Javier Carrasco , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rishi Gupta , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Matti Vaittinen , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/4] iio: light: add support for veml6031x00 ALS series Message-ID: References: <20260524-veml6031x00-v3-0-29165609b2b5@gmail.com> <20260524-veml6031x00-v3-2-29165609b2b5@gmail.com> <20260526185933.0084679f@jic23-huawei> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260526185933.0084679f@jic23-huawei> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, May 26, 2026 at 06:59:33PM +0100, Jonathan Cameron wrote: > On Sun, 24 May 2026 23:53:56 +0200 > Javier Carrasco wrote: ... > > +#include > > +#include > > +#include > > mod_devicetable.h is missing. Please check again for others. Yep. Please, follow IWYU principle. > > +#include > > +#include > > +#include Also add a blank line here to group out the linux/iio/*. > > +#include > > +#include > This isn't needed yet - bring it in when it is. > > > +#include ... > > + regmap = devm_regmap_init_i2c(i2c, &veml6031x00_regmap_config); > > + if (IS_ERR(regmap)) > > + return dev_err_probe(dev, PTR_ERR(regmap), > > + "Failed to set regmap\n"); It's okay to have it on a single line. ... > > + data->dev = dev; > > + data->regmap = regmap; This is not needed. Use one of them. ... I have a déjà vu that I have given already same comments. Why are they not addressed? -- With Best Regards, Andy Shevchenko