Devicetree
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Arpit Saini <arpit.saini@oss.qualcomm.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	Ayushi Makhija <ayushi.makhija@oss.qualcomm.com>,
	quic_rajeevny@quicinc.com, quic_vproddut@quicinc.com
Subject: Re: [PATCH 1/2] dt-bindings: display: panel: add Ilitek ILI7807S panel controller
Date: Sat, 6 Jun 2026 15:16:04 +0300	[thread overview]
Message-ID: <aiQPhPycW07t0U-6@umbar.lan> (raw)
In-Reply-To: <1ebc7c8a-b0de-4f25-b4dd-571909f9c67b@oss.qualcomm.com>

On Wed, May 20, 2026 at 06:24:20PM +0530, Arpit Saini wrote:
> Hi Dmitry,
> 
> On 5/18/2026 9:53 PM, Dmitry Baryshkov wrote:
> > On Mon, May 18, 2026 at 04:34:12PM +0530, Arpit Saini wrote:
> > > ILI7807S is a DSI display controller used to drive MIPI-DSI panels.
> > > The DLC DLC0697 1080x1920 LCD panel is based on this controller.
> > > 
> > > The panel requires a reset GPIO, backlight enable GPIO, I/O voltage
> > > supply (vddi), positive LCD bias supply (avdd) and negative LCD bias
> > > supply (avee). The panel operates in video burst mode with four data
> > > lanes using RGB888 pixel format.
> > > 
> > > Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
> > > ---
> > >   .../bindings/display/panel/ilitek,ili7807s.yaml    | 80 ++++++++++++++++++++++
> > >   MAINTAINERS                                        |  7 ++
> > >   2 files changed, 87 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili7807s.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili7807s.yaml
> > > new file mode 100644
> > > index 000000000000..93c511d03c00
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili7807s.yaml
> > > @@ -0,0 +1,80 @@
> > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/display/panel/ilitek,ili7807s.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Ilitek ILI7807S-based DSI panels
> > > +
> > > +maintainers:
> > > +  - Arpit Saini <arpit.saini@oss.qualcomm.com>
> > > +
> > > +allOf:
> > > +  - $ref: panel-common.yaml#
> > > +
> > > +properties:
> > > +  compatible:
> > > +    items:
> > > +      - enum:
> > > +          - dlc,dlc0697
> > > +      - const: ilitek,ili7807s
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +    description: DSI virtual channel
> > > +
> > > +  reset-gpios: true
> > > +
> > > +  backlight-en-gpios:
> > > +    description: Backlight enable GPIO (active high)
> > 
> > Is this actual GPIO or the GPIO-controlled supply?
> > 
> Addressed here https://lore.kernel.org/all/dd065ccd-d7cb-45b5-8733-64b4f6571b3d@oss.qualcomm.com/

It's not. Or, from your description, I can assume that it is a PWM
controller external to the panel. Please model it accordingly. I assume
there is no 'backlight-en' pin on the panel connector.

-- 
With best wishes
Dmitry

  reply	other threads:[~2026-06-06 12:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18 11:04 [PATCH 0/2] drm/panel: Add driver for DLC DLC0697 DSI panel Arpit Saini
2026-05-18 11:04 ` [PATCH 1/2] dt-bindings: display: panel: add Ilitek ILI7807S panel controller Arpit Saini
2026-05-18 16:23   ` Dmitry Baryshkov
2026-05-20 12:54     ` Arpit Saini
2026-06-06 12:16       ` Dmitry Baryshkov [this message]
2026-05-19 10:32   ` Krzysztof Kozlowski
2026-05-20 12:40     ` Arpit Saini
2026-05-20 13:19       ` Krzysztof Kozlowski
2026-05-20 13:26       ` Dmitry Baryshkov
2026-05-26 10:32         ` Arpit Saini
2026-06-06 12:13           ` Dmitry Baryshkov
2026-05-18 11:04 ` [PATCH 2/2] drm/panel: add Ilitek ILI7807S panel driver Arpit Saini
2026-05-18 13:50   ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiQPhPycW07t0U-6@umbar.lan \
    --to=dmitry.baryshkov@oss.qualcomm.com \
    --cc=airlied@gmail.com \
    --cc=arpit.saini@oss.qualcomm.com \
    --cc=ayushi.makhija@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_rajeevny@quicinc.com \
    --cc=quic_vproddut@quicinc.com \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox