From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A34A331A7B for ; Fri, 12 Jun 2026 01:18:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781227085; cv=none; b=arD/c/xb5z/srK0od1sTy5lFhipBhQDc54tsCS2H1rt3E3jN1NOB4zCvT8k9/lScOnfEJwidPHeD89KdIxhMnmjTXH3e+OW9uSYLwfJdcdHN4bd7HNcloRvUnC0c4OEDDdWYgmzcDqLWzT4rtVAQ1xmS8seShbxWdp7Om2Wg7LU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781227085; c=relaxed/simple; bh=Zuowp69okHqoeqjXee0h4XdV2JsffR3X6Im4oI1USEs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KsUwaPcebd40RlRk2hJ+m9WooUe9QiFzeLBoxf3mY2aKNQRc3SbTC92LYL2Y5HY+wb9YvHOWlWPuHdTm4hknpH1RWukMSDiqKR0t3P1T4v4GaNatW1VptSC7innwguXf+9QEUrGGQP981FVGS901b11xS6sYHnRWpsjKR9dSLCE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XBu3YVp9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZM6cEeLq; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XBu3YVp9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZM6cEeLq" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65BMUZId1864462 for ; Fri, 12 Jun 2026 01:18:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=4EqFMpSpAm2KuA9gUkjE2CCc /4B8cxyegXiUK2f5fww=; b=XBu3YVp99cQ3B1+pNoy0HhauSovp/N5ocz9wrTuE st0uvVVGpJC/imYHuAyuCfMWq9Y2f+YFz3tEoEE707ud5wssH40gKLpi/7K0oaAj ynXYaAHZBL5QkrkN/Rgme/fRnO9EAQ0rReo6w/dRP8DfcJsNObvUaSmWcoUcdzJX 1pXAFWvtT27wqlQMz/UMHgLzWSEZVR6kWzCLllsvQIYam2/N4ENo/3UvPrXE04Ot PgpUQymgMW4sUc9FfTMt27QSzn7wU0o3rDYWQFR7/aWOEktvTCHmm0iZ9Fx7H/xU oYK7xIcTvXDJPEzw4nJIaaIDnwsCt99q2yARUQp9pcmtpw== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er1xchekj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Jun 2026 01:18:01 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-304f23c55b2so761218eec.0 for ; Thu, 11 Jun 2026 18:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781227081; x=1781831881; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4EqFMpSpAm2KuA9gUkjE2CCc/4B8cxyegXiUK2f5fww=; b=ZM6cEeLqLkQIh+NJ+1ZYTOAwTceSCeGbC9RzQ6nctkrAE4SyQZL11DNU4EMF0oNA7Z ZgdrfCTrP/hB6DYsl4jjne5n0qjmmaQaNE2+/nxhuemfaVoJ7KIh8cuc6ZZF1P+aL8MY a8cMuBIQnMDc8pAyWsPzTu57dG/4CGNNg+Y09QgwwcNVbRDvLVjEwHD1Uo0svGFxzoaH COA8vsCPYtPGf2Nj5M96dO4kk4O+nXvH31UmnHiTzL9tiCrF3vnGgoJHUDWGg2Lud+n3 y/uYDJ5rCVsilBixmTUO4v66+d4Xo8FKK2ohGuwQh3doD7dpy7l0DxSPaab5+ShxvW0o NN1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781227081; x=1781831881; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4EqFMpSpAm2KuA9gUkjE2CCc/4B8cxyegXiUK2f5fww=; b=MYkuiDqtCepFF6/aXyL7mars7ZuAHBqEUtuS4mD0eL7jrsxVQhzJ43G7GJE8qnULt9 cVXHMD3bNfWfLglaVPNJXvJJbbLIr5BODRQ2JVcylAE30CoCXBxwu6aW5nqEewFz7D8j LjVpW+P5zkQEL6pzF+ysLqAzQX6VrTpBzxkDAJHgNUD7TtCvnjj/klOihb9X9TIbto/S rudBA4RlI+p7ojkHeSn59ajl9Ib3WUZRhTcowLDiR7YuRyBI2npxfro/VUYWQw0Agen1 U9Abtmzdx7sXvMhJg055VniIJgzoC/41XM70T9+YsN88Y8l9TRrmOwS30LyCMCt7wGXU jIGQ== X-Forwarded-Encrypted: i=1; AFNElJ+jkrjGmhk8ZcJrXwrTScTuLrzoF2lIyqahanJprostGidJGjv1TRAbkTJ5BW5mlXj18gZrP3DlfcEk@vger.kernel.org X-Gm-Message-State: AOJu0YyqSHRIJfKVsSYPzX3HnndOdMQ/AS4E0nJn2t1mEKs5eG0AlQKY Z+ajbsZLZWhOsQg9DBiVMlubOsaFJtazNtznNIK+up4B1fqxXxm4YYlJhbZr353jcyIWb1TThJD FG+DvMbyRm3geRjESUaCpXzTBdzVQMAnvDuw8vupKjZJaO7yqVTTwbkdSF8qR4Fd5 X-Gm-Gg: Acq92OGx/z6SVM5YyVWPSyr1F80eslsfzixsdxfLiUjXymRbNqWRrSqRIs1wSVlLy+T 4dg4z1MSn0u2rpfpu2RqwNYTXBwLbyMYL4BgaRoPlb46vSvXCXNrTwZ8dYTLCZLf4OgEgBa271e f5f8hXfx73STX3wYad6NUlsJSAs/NkBRruJRMeio1UavTNNSjAmg7mg1WK8X3MJErYggz/ReXJn J9J3D16O5qn3orclwgXDolHsSWf+lsMWGkUl+Yq6a0sUR1UA/CaVCk3WfdILfqhFq0oPj6bcXyw Bv3Lf0Xv60Mkm6aIptzMD+oYC2lhCoB3W+ii33Al8C8AoGsu7UdQlbmHFpabd6cAvpScJBAg8DR O2OHILF+i7vDhsrYTqoKTzkPDWcgWsInzIG2I928ngUejseT4wmjFmjDLQNQ+5dEiJiKnMKeJFs WWGA== X-Received: by 2002:a05:7300:3c2c:b0:304:8361:a87e with SMTP id 5a478bee46e88-308200c5969mr426760eec.33.1781227080821; Thu, 11 Jun 2026 18:18:00 -0700 (PDT) X-Received: by 2002:a05:7300:3c2c:b0:304:8361:a87e with SMTP id 5a478bee46e88-308200c5969mr426735eec.33.1781227080168; Thu, 11 Jun 2026 18:18:00 -0700 (PDT) Received: from hu-mattleun-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e5fefecsm1203063eec.13.2026.06.11.18.17.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 18:17:59 -0700 (PDT) Date: Thu, 11 Jun 2026 18:17:57 -0700 From: Matthew Leung To: Dmitry Baryshkov Cc: Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: PCI: qcom: Document the Hawi PCIe Controller Message-ID: References: <20260529-hawi-pcie-v2-0-de87c6cc230c@oss.qualcomm.com> <20260529-hawi-pcie-v2-1-de87c6cc230c@oss.qualcomm.com> <2tenqkmwcr2gshtjwh44pvban4gtlzcgrm3iibkfrs4zh6vphb@h5losfunylr6> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2tenqkmwcr2gshtjwh44pvban4gtlzcgrm3iibkfrs4zh6vphb@h5losfunylr6> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDAwOSBTYWx0ZWRfXwk7ptu0T6rka jPQsrsO7uDNgH/r33scN4COjZL68UdlF/4gnuxIJpRl9EaR5wNy9IVctB7+jXzdiVLTUBpaKTM2 QrsNE24nhO0ocdaOJK/M5t+buMZZQcEgQa7bqgWuZzvmubhCncIvlyWeFSQHYfXWgYtXzp75TNo ZcA6T/biw9B4lVF++v9wmifYok5pWcNVW7oRfReieKuQUBVIYDlwBjgI+kHCJ+lANeiAWislUsR fhb1nbV6RxC7oL+TO3n+Zh9a0mNr6U3qIGDhGiDcla4/BLuOizeLdjpU50QrYPyqsk7qJLPkrMJ MbF9zK/pwhfUQcwcjtGYoyAjdIXM36AbjdencHUKnfPHOlf/qiGEFReh42ca5unO03jSOMVwnfg EJCBRfwUCyh43wibm3oZL6YGjlbTywsfAeQeu9hc1SJDuZf87UYssMW+kz5W20G6NvzQMXjQ5e3 wWfnhIYq0kIQclyJ1RA== X-Proofpoint-GUID: 6wMMnRV0gXk5XF5YYqmf1LSxm_wioVSL X-Proofpoint-ORIG-GUID: 6wMMnRV0gXk5XF5YYqmf1LSxm_wioVSL X-Authority-Analysis: v=2.4 cv=NZPWEWD4 c=1 sm=1 tr=0 ts=6a2b5e49 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=kj9zAlcOel0A:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=k8qvQEqTjxYPBieS1nsA:9 a=CjuIK1q_8ugA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDAwOSBTYWx0ZWRfX2E1LuyAR1trQ 4fPSUpnH7CsREWwxXOdlhOSDeWxP4cgwhywDTKz1A8tYyE58r0cT4xj9218ahAWyS05PG7L828X 5DRjBRgvAD4tCdDUyOhQHyJF8nVBHLY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_05,2026-06-11_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 bulkscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120009 On Sun, Jun 07, 2026 at 11:01:10PM +0300, Dmitry Baryshkov wrote: > On Fri, May 29, 2026 at 01:10:08AM +0000, Matthew Leung wrote: > > Add a dedicated schema for the PCIe controllers found on the Hawi > > platform. > > > > Signed-off-by: Matthew Leung > > --- > > .../devicetree/bindings/pci/qcom,hawi-pcie.yaml | 204 +++++++++++++++++++++ > > 1 file changed, 204 insertions(+) > > > > + > > +examples: > > + - | > > + #include > > + #include > > + #include > > + #include > > Stop referencing clocks and interconnect header files. Replace used nocs > with ephemeral values. > > > + #include > > + > > + soc { > > + #address-cells = <2>; > > + #size-cells = <2>; > > Not looking around should be a sin. Take a look at other Qualcomm PCIe > bindings. Compare them to yours. Then fix yours to follow. > > Hint: the extra soc node is useless. This is just an example, so use the > default, 1 cells for address and size. Thank you for the feedback. This new binding follows the examples set in the qcom,pcie-sm8x50 bindings and retains the same formatting (extra soc node and header references). I understand the example can be simplified with your suggestions but want additional confirmation that these will be the convention for new bindings going forward. > > > + > > + pcie@1c00000 { > > + compatible = "qcom,hawi-pcie"; > > + reg = <0 0x01c00000 0 0x3000>, > > + <0 0x40000000 0 0xf1d>, > > + <0 0x40000f20 0 0xa8>, > > + <0 0x40001000 0 0x1000>, > > + <0 0x40100000 0 0x100000>; > > + reg-names = "parf", "dbi", "elbi", "atu", "config"; > > + ranges = <0x01000000 0x0 0x00000000 0x0 0x40200000 0x0 0x100000>, > > + <0x02000000 0x0 0x40300000 0x0 0x40300000 0x0 0x3d00000>; > > + > > + bus-range = <0x00 0xff>; > > + device_type = "pci"; > > + linux,pci-domain = <0>; > > + num-lanes = <2>; > > + > > + #address-cells = <3>; > > + #size-cells = <2>; > > + > > + clocks = <&gcc GCC_PCIE_0_AUX_CLK>, > > <&gcc_pcie_0_aux_clk>, etc. > > > + <&gcc GCC_PCIE_0_CFG_AHB_CLK>, > > + <&gcc GCC_PCIE_0_MSTR_AXI_CLK>, > > + <&gcc GCC_PCIE_0_SLV_AXI_CLK>, > > + <&gcc GCC_PCIE_0_SLV_Q2A_AXI_CLK>, > > + <&gcc GCC_AGGRE_NOC_PCIE_AXI_CLK>, > > + <&gcc GCC_CNOC_PCIE_SF_AXI_CLK>; > > -- > With best wishes > Dmitry