Re: [PATCH v3 8/8] arm64: dts: freescale: imx95: Add NXP neoisp device tree node

[Frank Li <Frank.li@oss.nxp.com>]

On Mon, Jun 15, 2026 at 01:25:49PM +0200, Francesco Dolcini wrote:
> On Mon, Jun 15, 2026 at 11:56:15AM +0200, Antoine Bouyer wrote:
> > On 6/14/26 11:05 AM, Francesco Dolcini wrote:
> > > On Fri, Jun 12, 2026 at 03:20:39PM +0200, Antoine Bouyer wrote:
> > > > Add neoisp device tree node to imx95.dtsi and enable it by default in
> > > > 19x19 evk board.
> > > >
> > > > Signed-off-by: Antoine Bouyer <antoine.bouyer@nxp.com>
> > >
> > > ...
> > >
> > > > diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi b/arch/arm64/boot/dts/freescale/imx95.dtsi
> > > > index d6c549c16047..5543a6cb1250 100644
> > > > --- a/arch/arm64/boot/dts/freescale/imx95.dtsi
> > > > +++ b/arch/arm64/boot/dts/freescale/imx95.dtsi
> > > > @@ -1867,6 +1867,17 @@ pmu@49252000 {
> > > >                        };
> > > >                };
> > > >
> > > > +             neoisp0: isp@4ae00000 {
> > > > +                     compatible = "nxp,imx95-neoisp";
> > > > +                     reg = <0x0 0x4ae00000 0x0 0x8000>,
> > > > +                           <0x0 0x4afe0000 0x0 0x10000>;
> > > > +                     interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>;
> > > > +                     clocks = <&scmi_clk IMX95_CLK_CAMCM0>;
> > > > +                     clock-names = "camcm0";
> > > > +                     power-domains = <&scmi_devpd IMX95_PD_CAMERA>;
> > > > +                     status = "disabled";
> > > > +             };
> > >
> > > Why the node is disabled?  If the node is wholly described in
> > > imx95.dtsi, it should be enabled.
> >
> > Actually, all nodes are disabled in the SoC dtsi, and enabled on the board
> > dts file, even if fully described on the dtsi. So I used same approach for
> > neoisp.
>
> This is not correct. Please check what we do for the GPU/VPU[1] and NPU [2],
> for example. Is there a reason to do it differently for the ISP?

I agree on Francesco. It is supposed be enabled by default if you can use
run time pm to manage clock and power.

Frank

>
> Francesco
>
> [1] arch/arm64/boot/dts/freescale/imx8mm.dtsi
> [2] arch/arm64/boot/dts/freescale/imx93.dtsi
>