Re: [PATCH v9 2/9] drm/bridge: fsl-ldb: Get the next non-panel bridge

[Frank Li <Frank.li@oss.nxp.com>]

On Fri, Jun 12, 2026 at 02:58:33PM +0300, Laurentiu Palcu wrote:
> From: Liu Ying <victor.liu@nxp.com>
>
> The next bridge in bridge chain could be a panel bridge or a non-panel
> bridge.  Use devm_drm_of_get_bridge() to replace the combination
> function calls of of_drm_find_panel() and devm_drm_panel_bridge_add()
> to get either a panel bridge or a non-panel bridge, instead of getting
> a panel bridge only.
>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/gpu/drm/bridge/fsl-ldb.c | 31 ++++++++++++-------------------
>  1 file changed, 12 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c
> index 9bfaa3f933709..bd03c36ee696c 100644
> --- a/drivers/gpu/drm/bridge/fsl-ldb.c
> +++ b/drivers/gpu/drm/bridge/fsl-ldb.c
> @@ -15,7 +15,6 @@
>  #include <drm/drm_atomic_helper.h>
>  #include <drm/drm_bridge.h>
>  #include <drm/drm_of.h>
> -#include <drm/drm_panel.h>
>
>  #define LDB_CTRL_CH0_ENABLE                    BIT(0)
>  #define LDB_CTRL_CH0_DI_SELECT                 BIT(1)
> @@ -86,7 +85,6 @@ static const struct fsl_ldb_devdata fsl_ldb_devdata[] = {
>  struct fsl_ldb {
>         struct device *dev;
>         struct drm_bridge bridge;
> -       struct drm_bridge *panel_bridge;
>         struct clk *clk;
>         struct regmap *regmap;
>         const struct fsl_ldb_devdata *devdata;
> @@ -119,7 +117,7 @@ static int fsl_ldb_attach(struct drm_bridge *bridge,
>  {
>         struct fsl_ldb *fsl_ldb = to_fsl_ldb(bridge);
>
> -       return drm_bridge_attach(encoder, fsl_ldb->panel_bridge,
> +       return drm_bridge_attach(encoder, fsl_ldb->bridge.next_bridge,
>                                  bridge, flags);
>  }
>
> @@ -296,9 +294,8 @@ static const struct drm_bridge_funcs funcs = {
>  static int fsl_ldb_probe(struct platform_device *pdev)
>  {
>         struct device *dev = &pdev->dev;
> -       struct device_node *panel_node;
>         struct device_node *remote1, *remote2;
> -       struct drm_panel *panel;
> +       struct drm_bridge *next_bridge;
>         struct fsl_ldb *fsl_ldb;
>         int dual_link;
>
> @@ -321,36 +318,32 @@ static int fsl_ldb_probe(struct platform_device *pdev)
>         if (IS_ERR(fsl_ldb->regmap))
>                 return PTR_ERR(fsl_ldb->regmap);
>
> -       /* Locate the remote ports and the panel node */
> +       /* Locate the remote ports. */
>         remote1 = of_graph_get_remote_node(dev->of_node, 1, 0);
>         remote2 = of_graph_get_remote_node(dev->of_node, 2, 0);
>         fsl_ldb->ch0_enabled = (remote1 != NULL);
>         fsl_ldb->ch1_enabled = (remote2 != NULL);
> -       panel_node = of_node_get(remote1 ? remote1 : remote2);
>         of_node_put(remote1);
>         of_node_put(remote2);
>
> -       if (!fsl_ldb->ch0_enabled && !fsl_ldb->ch1_enabled) {
> -               of_node_put(panel_node);
> -               return dev_err_probe(dev, -ENXIO, "No panel node found");
> -       }
> +       if (!fsl_ldb->ch0_enabled && !fsl_ldb->ch1_enabled)
> +               return dev_err_probe(dev, -ENXIO, "No next bridge node found");
>
>         dev_dbg(dev, "Using %s\n",
>                 fsl_ldb_is_dual(fsl_ldb) ? "dual-link mode" :
>                 fsl_ldb->ch0_enabled ? "channel 0" : "channel 1");
>
> -       panel = of_drm_find_panel(panel_node);
> -       of_node_put(panel_node);
> -       if (IS_ERR(panel))
> -               return PTR_ERR(panel);
> -
>         if (of_property_present(dev->of_node, "nxp,enable-termination-resistor"))
>                 fsl_ldb->use_termination_resistor = true;
>
> -       fsl_ldb->panel_bridge = devm_drm_panel_bridge_add(dev, panel);
> -       if (IS_ERR(fsl_ldb->panel_bridge))
> -               return PTR_ERR(fsl_ldb->panel_bridge);
> +       next_bridge = devm_drm_of_get_bridge(dev, dev->of_node,
> +                                            fsl_ldb->ch0_enabled ? 1 : 2,
> +                                            0);
> +       if (IS_ERR(next_bridge))
> +               return dev_err_probe(dev, PTR_ERR(next_bridge),
> +                                    "failed to get next bridge\n");
>
> +       fsl_ldb->bridge.next_bridge = drm_bridge_get(next_bridge);
>
>         if (fsl_ldb_is_dual(fsl_ldb)) {
>                 struct device_node *port1, *port2;
>
> --
> 2.51.0
>