From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F1AC3C8C7F for ; Tue, 16 Jun 2026 04:26:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781583995; cv=none; b=atBS0fBce26rN+o7aQyup6f+EfAbTWzDb4Cc5K6+4iQwurMlvScoh0G1kjHGxmOX9SqA+WCTkViGUhoGi+UU69znWRC15vfv9GNLU+0JPZBqoc4xlYGQ7UggTnQQX3+nYPzBHi8VE3DGwap2VWofryajWiQfYQBr2i/+1s4WgM4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781583995; c=relaxed/simple; bh=oo4tfyy8/lTcDz9sLBYLwqwvpecf+BueTrMqZlBkdJA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fzfrFadUOOnaOkrNgbq7KxvZ/oY1Pjd4vMNlrvWJzSXjwDpfC3rPA//jZ5ZGrlbYmjHm149xb970uNsVlbDNmnoBcDKVdzWu3PaFjnrwHKvc406SaeMAx2//qS16LZr6iMNiARFsh1wlJOTUc4Uc1fXI843NTx9d8Qq2qhDClUE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IxVDiETX; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IxVDiETX" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-30bb2df6fbbso345754eec.0 for ; Mon, 15 Jun 2026 21:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781583993; x=1782188793; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=bY4/S5kAo7rT958o4WJs5aY2AIH3N1nSwFvgkKoR7DU=; b=IxVDiETXMu9w5l/RPm4LuK+2KnGgZJ4HOIUnfo+bHinIg1ulcPcR687NvE/6dW/bpW OUj9Zha+X20RjcukD7hNlxX1Mx4L73AaoG/42u1t24jnj4I/Osg5U58zAsqd48u0g3S7 ZhKNWf7hVdxeLjAzciO+KqM/h7phqeedB3yslKahoB4OIco23FB56/ox1h9BW4GSiQPz iAWYZLtvTkfcIBn0QiH3UaMXnVhddQ07NHNGrxdfoAz3PouEPmNBqG6EplQeJWbZJskm E0Z4+758FRO22vnty66xXhAY3oq3jFe4AUvEmkPH2ifCNR2+hjz8OnTtFw6KWskZRyW4 vgUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781583993; x=1782188793; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bY4/S5kAo7rT958o4WJs5aY2AIH3N1nSwFvgkKoR7DU=; b=WIdN1FWmYJAJCqHv7n9MgkrFTsANr1jx9o01INs986K332HpJZutfZnnF7jIJAMAOP izS1TMdm6tUd5IwAgjce+G5D8+yi54wrrlyHThfuKQD8pfuVR2Sl7luax2JX+fA9If3c F7080k+zY1MxTtK49CZ+bZvMPfhEcRAy4AIp9YXDiKhIfFuHD2RDf3ljf9WDDTwbGp+z bQ5H/G2ZioQNrswfWOA+Q4+3hIRWtr9tMTwmZOWMue688FWv4Dit8r9MORDrALjjdpUs DbtBDe0raW8JcyK326WZ2b8EP+LrcWr56pCY6zfEm1+97Gyhl8RU78gZBHuf27hoRz35 Gz0Q== X-Forwarded-Encrypted: i=1; AFNElJ+jFmGrEfO3cuVPcD/WvBFX8HI870g/raj1kQtddSqOzH4hCZIJ1No1TGpNOzIjpnJXP+pCgzNmjuY9@vger.kernel.org X-Gm-Message-State: AOJu0YxmXeh7UKRfjqS/I6es/mBJTerZAS+qokV4clamFRWMzYvLrTOt u02shXcPiAJcFVSOOja/WVEN3VYSkG0IReVMp4eoW7cOg0/7HPbskAJ/ X-Gm-Gg: Acq92OEpTotI2ykWAp8IRvfXTmOUvJeuewRnHtcM6Lv5J812J091gZOT10Jf68CCG5w ZS5Y545D/fTky4uurSId6CdPO+EACVdMM2Sv+JLzGEOGLi6fyry4Z8GoPTYxRMCM+Zvlbu872Pi FYYNQu3Wchgsfbadun6dH+mZ9GWtXbwb972Ph2vsnZA9ot1bIegpYppw8kaFJVQWCYHJoFV8ZMK GoAVRXJ1u5jGNoU3ntmCfmEnLsjklYyYWT67F+aqOP8Xe5Tjf7y1uEPNu84v0cVMfRYu4e7nx8e ZUgakKsUe6WXFPUPMyo3Q07U/yGIVod6da86WofbZMNkovEfPLyTx112oVhAnktrM+PZWuMowWr dJLYzlKlkBM1HJjEUqTilnwZwy5wh1qzKORn8iOwlLDwGx+TJk90DOSDlflzz5c6DlcihVSV/sY 4U/FmEjacuB6DNa3rHO9bY7Ip0r2MPcgfpJUvkVu5HSs/jPGwvU4ntQtSsOq/NJEJj X-Received: by 2002:a05:7300:3b28:b0:304:e72a:d4d1 with SMTP id 5a478bee46e88-30ba5f4b95emr1163025eec.30.1781583993222; Mon, 15 Jun 2026 21:26:33 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:3714:f5c2:9b83:3df1]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081eb8f8b2sm17660379eec.27.2026.06.15.21.26.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 21:26:32 -0700 (PDT) Date: Mon, 15 Jun 2026 21:26:29 -0700 From: Dmitry Torokhov To: Svyatoslav Ryhel Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Pavel Machek , Sebastian Reichel , Ion Agorria , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v8 4/7] input: keyboard: Add driver for ASUS Transformer dock multimedia keys Message-ID: References: <20260528053203.9339-1-clamor95@gmail.com> <20260528053203.9339-5-clamor95@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260528053203.9339-5-clamor95@gmail.com> Hi Svyatoslav, On Thu, May 28, 2026 at 08:32:00AM +0300, Svyatoslav Ryhel wrote: > From: Michał Mirosław > > Add support for multimedia top button row of ASUS Transformer's Mobile > Dock keyboard. Driver is made that function keys (F1-F12) are used by > default which suits average Linux use better and with pressing > ScreenLock + AltGr function keys layout is switched to multimedia keys. > Since this only modifies codes sent by asus-ec-keys it doesn't affect > normal keyboards at all. I think using input handler to intercept ScreenLock + AltGr is quite awkward. I think this also passes the original key events (unless you make it a filter not a regular handler). I do not see benefit for reacting to AltGr+ScreenLock on other keyboards to activate the special mode on this one. So given the fact that you already mange the data stream when you split it into "serio" ports, maybe just intercept this key combo right there and create the input device and signal input events right there? Thanks. -- Dmitry