From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 730A625B08E for ; Sat, 20 Jun 2026 04:57:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781931430; cv=none; b=hRRfV66FBUl0mZS4gj9PpFUtWGqHO0yS1Tgh39l6YkGAFlv7TZd5rngW7AkuPsMEJVQHPxUreinuduSKpoAqu5kneBnm+cAEVbOeNiS+BvxU4TOV4uWO/c/0vo3gl9/rSDlF3biD6ffly4b070pp8Gyr1vWi5ksoHEvd1jCJUds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781931430; c=relaxed/simple; bh=hIXL+7zdNS9oh3NGK9e1dh1RAZ6rFnUHSYtYlJpahjk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JzoHBwxg2dHqmo+bUv4GGhTGZSQrhP++JUgFzfA6uBSWqAprS3IOtrG87FC1aEDmTxNGGip1h2nLYqqmM9zf1aeJnfhlYL6aTT5Co9jtJgUL/YIul3c/HxIBpsgmmTfmopey78pZl/Ow/FRLhr9AvLfn3tFDBlXhNlXsUvrXng8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A/alKpST; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A/alKpST" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-84537777d45so2051731b3a.3 for ; Fri, 19 Jun 2026 21:57:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781931429; x=1782536229; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TAk+4QDI4jdh7tin51npXPOxqv16LUgVCNzAQTOEJDA=; b=A/alKpSTpJvzKkr/E7WAmQI5mujS3gihXN+u3FaMVCXSruxYMCk5W0wAWrZn0fSUcN OwYEs0PFN/E0FGoGDl1pJmtmxhZVEfWhpXmTeE4pQjO7aqp3xWaqkfNoYBEKzu0eUpGr w93QDfMR9x9G7okMgWZ2kGdWZBvJAdMwhk+PK3s9lVSDQy8cuTIthgglTaocAIR9eCdi wiYRkZ0dDjHUvs+4BNrJzbsDD1aq1GErbj7KJtR40yUKyodGofiFQfeo0/t23shVeYpW DVfsxkPWF8oKBuA2X/qy3jHL7yeH0iw+RqRSkEDbvm442D3pXJU8kY3QMyiJum3V4h2p 17Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781931429; x=1782536229; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TAk+4QDI4jdh7tin51npXPOxqv16LUgVCNzAQTOEJDA=; b=B3YUWupKy2aJS7xN0/LAVDWQKnNYpsXvfStWn6E1f2/yf2N2ocRWHm+QfPoI3CeaU9 OpbXtE4nNsezp91XKY6p38vEtFST+q/WmE8QjIWuz2pIXE73rntlaoZQxP++wBZ120rm ssMLUHDayBkIY2jkAK3DN3tsgH9atMqa7d+BCsDCyHL/dfTW4A/RHDlMVqZpTpdfAq9N 4hPWP8gxqNiAyp2dKOdWRxavpHbhMhMhPryh7f3uoLfo0mXQo2dn6P9fNdqnWSNBa/WS B7aIwt3PHiIkjzyBTCSQgvfXN2E5fpyCc1M87jlMBFQpodOVY6vw8NYB0JN3Koq2AMUd 8POg== X-Forwarded-Encrypted: i=1; AFNElJ9IcC04pY27qDJvXKisusLUJMi3aZ9OrDfuw4TNeY0BV6lcl7yIBbIxftozIsLaXGQEQIqpgFlNbBb2@vger.kernel.org X-Gm-Message-State: AOJu0Yw20UuN4Y1asw2HZ9SjQCKkSLO6Vr1H35UfJTVjeVeVVrgQry5G zvq1Y8dWKhNqpkcuUtT6vyRpg9MYWZ+JnMSyZTM0c2WcF85qLuHUqrpw X-Gm-Gg: AfdE7ckwb2dhOxvr0cl1xIbZYs+12yHup5rwhsvyKgpepEbP6PmDbdb/z051mprPVnJ K4IONJqk4uZwzpwurpSv/ETaAVncCadnc5OxpF1GQSUnbk5SKg+ajnncRmoSn5yK5s1p5+GHLMu PsDV4lMvnm+ujUc+7Lymp8003I9DxTMJ4d8mVdR9FHONiEEU+KNTdvkWrjnpD4GwzJzrr37ehBI 8kdpb1sYk09GNOC0eKyp8Aol77wIIpWadIxgfvcW6u4uxd6S4xnGbcUIbR4NPYopiAEzrWAdA09 blif1ErjuAu9s5epT9/lHLTj7b8+sU7Cnndd8fhvcpQH03kUPR+2Lopnz5qKbQE4Ax0BCdSaj1C gJzyuHMKwBl5IZKo1Uhv2f1a6rV8Sm4Y2s6K1mJuOIzXZqUoXN6uupx6IrRfWPgnxGUuLkm3kll 58fWX0A59WnxsCMwCEZ80TG7ufhKz+2s8L X-Received: by 2002:a05:6a00:1995:b0:842:688f:308d with SMTP id d2e1a72fcca58-845508a1496mr6337770b3a.30.1781931428739; Fri, 19 Jun 2026 21:57:08 -0700 (PDT) Received: from page.local ([2402:a00:163:2ce9:843c:c4d1:e350:dd10]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84564ea22c7sm871944b3a.44.2026.06.19.21.57.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2026 21:57:07 -0700 (PDT) Date: Sat, 20 Jun 2026 10:27:00 +0530 From: Ajit Singh To: Konrad Dybcio Cc: Bjorn Andersson , Bartosz Golaszewski , Dmitry Baryshkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/3] arm64: dts: qcom: Add Vicharak Axon Mini Message-ID: References: <20260607113658.25117-1-blfizzyy@gmail.com> <20260607113658.25117-4-blfizzyy@gmail.com> <39228ace-9404-4ade-bcb1-28e763548b7f@oss.qualcomm.com> <5c80c430-8bc7-4d03-be7e-c6dd518705e7@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Fri, Jun 19, 2026 at 05:30:40PM +0530, Konrad Dybcio wrote: > On 6/18/26 8:29 AM, Ajit Singh wrote: > > On Tue, Jun 16, 2026 at 02:10:44PM +0530, Konrad Dybcio wrote: > >> On 6/12/26 6:16 AM, Ajit Singh wrote: > >>> On Wed, Jun 10, 2026 at 02:58:19PM +0530, Konrad Dybcio wrote: > >>>> On 6/7/26 1:36 PM, Ajit Singh wrote: > >>>>> Add DTS for the Vicharak Axon Mini board based on the Qualcomm > >>>>> QCS6490 SoC. > >>>>> > >>>>> This adds debug UART, eMMC, UFS, SDIO WLAN, USB 2.0 host, PCIe > >>>>> support along with regulators. > >>>>> > >>>>> The UFS ICE block is kept disabled because enabling it currently causes > >>>>> an SError during qcom_ice_create() on this board. UFS works without ICE. > >>>>> > >>>>> Signed-off-by: Ajit Singh > >>>>> --- > >>>> > >>>> [...] > >>>> > >>>>> + vreg_l12c_1p8: ldo12 { > >>>>> + regulator-name = "vreg_l12c_1p8"; > >>>>> + regulator-min-microvolt = <1800000>; > >>>>> + regulator-max-microvolt = <2000000>; > >>>>> + regulator-initial-mode = ; > >>>>> + > >>>>> + /* > >>>>> + * VREG_L12C_1P8 supplies the Ampak WLAN/BT module > >>>>> + * VDDIO and the external 32.768 kHz oscillator. > >>>>> + */ > >>>> > >>>> Sorry for the long review timelines on the previous patch, many of us > >>>> were out for conferences.. > >>>> > >>>> Is the oscillator used for that WLAN module? Would you ideally like to > >>>> be able to turn it on/off? > >>> > >>> yes, oscillator is used for WLAN modules. Oscillator is powered from the same > >>> VREG_L12C rail as WLAN VDDIO, so there is no separate regulator control to put > >>> in pwrseq. So I think this will work fine? > >> > >> Probably? My point is that you marked it as always-on, so it will *never* > >> turn off right now. For e.g. Qualcomm wifi, there's some timing spec that > >> needs to be met wrt delays between toggling various regulators and GPIOs > >> going to the module, hence I suggested you may need some pwrseq inbetween > >> to achieve reliable powering on/off > >> > > Right, I checked the module timing requirements. > > > > The module requires VBAT to be present before or at the same time as VDDIO, and > > WL_REG_ON to be asserted only after VBAT/VDDIO are valid, around 2 sleep-clock > > cycles later. > > > > On this board, VBAT is the shared VCC_3V3 rail and is enabled by hardware, so > > it is already present before VDDIO. VREG_L12C supplies WLAN/BT VDDIO and is > > kept on. The WL_REG_ON timing is handled by the existing mmc-pwrseq-simple > > reset GPIO/delay before SDIO enumeration. > > > > So I think the current sequencing matches the module timing requirement. > > Since the sequencing is handled, can we drop the always-on property, > perhaps by describing the SDIO WLAN? > > e.g. in arch/arm/boot/dts/st/ste-ux500-samsung-codina-tmo.dts there is: > > /* WLAN SDIO channel */ > mmc@80118000 { > arm,primecell-periphid = <0x10480180>; > max-frequency = <50000000>; > bus-width = <4>; > non-removable; > cap-sd-highspeed; > pinctrl-names = "default", "sleep"; > pinctrl-0 = <&mc1_a_2_default>; > pinctrl-1 = <&mc1_a_2_sleep>; > /* > * GPIO-controlled voltage enablement: this drives > * the WL_REG_ON line high when we use this device. > * Represented as regulator to fill OCR mask. > */ > vmmc-supply = <&wl_reg>; > > #address-cells = <1>; > #size-cells = <0>; > status = "okay"; > > wifi@1 { > compatible = "brcm,bcm4334-fmac", "brcm,bcm4329-fmac"; > reg = <1>; > /* GPIO216 WL_HOST_WAKE */ > interrupt-parent = <&gpio6>; > interrupts = <24 IRQ_TYPE_EDGE_FALLING>; > interrupt-names = "host-wake"; > pinctrl-names = "default"; > pinctrl-0 = <&wlan_default_mode>; > }; > }; > > most notably though, it seems that the brcmfmac driver doesn't even use > the regulator framework, probably because all of the SDIO WLANs that > Linux supports were wired in a more "embedded" way, where the V(Q)MMC > supplies were enough.. unless it's the case here too? It might not be possible to drop regulator-always-on for VREG_L12C here. The SDHC2 host already has its own vmmc/vqmmc rails: vqmmc-supply = <&vreg_l2c_1p62>; vmmc-supply = <&vreg_l6c_2p96>; VREG_L12C is a separate module-side VDDIO rail for the AP6272S WLAN/BT module. There is no separate GPIO-controlled enable for this rail; as you said, since brcmfmac does not appear to consume an extra VDDIO regulator from the SDIO child node, so unless there is a preferred way to model this module-side VDDIO rail, I think VREG_L12C still needs to stay always-on. > > Konrad Ajit