Re: [PATCH 1/2] dt-bindings: arm: add MBa93xxCA as mainboard for TQMa91xxCA and TQMa91xxLA SOM

[Frank Li <Frank.li@oss.nxp.com>]

On Tue, Jul 07, 2026 at 09:20:07AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The patch introduces duplicated and repetitive text in the dt-binding description block and contains a factual typo in the commit message.
> --
>
> --- Patch [1]: [PATCH 1/2] dt-bindings: arm: add MBa93xxCA as mainboard for TQMa91xxCA and TQMa91xxLA SOM ---
> commit 3332dfa95ce8d051969053f3ea74bbf075143869
> Author: Markus Niebel <Markus.Niebel@ew.tq-group.com>
>
> dt-bindings: arm: add MBa93xxCA as mainboard for TQMa91xxCA and TQMa91xxLA SOM
>
> This commit documents the MBa93xxCA starterkit mainboard for the TQMa91xxCA
> and TQMa91xxLA System-on-Modules. It adds the corresponding compatible string
> and updates the board descriptions in the fsl.yaml binding.
>
> > TQMa93xxLA and TQMa93xxCA are two series of feature compatible SOM
> > using NXP i.MX91 SOC in 11x11 mm package.
>
> [Severity: Low]
> This isn't a bug, but there appears to be a typo in the SOM series names here.
> Should TQMa93xxLA and TQMa93xxCA be TQMa91xxLA and TQMa91xxCA since they use
> the i.MX91 SOC?

Look likes correct, please double check it.

Frank

>
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 86876311ec59a..84c4311cf7c30 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> [ ... ]
> >            soldered on an adapter board or for the connector variant
> >            MBa91xxLA mainboard is a single board computer using the solderable
> >            SOM variant
> > +          MBa91xxCA mainboard can be used as starterkit for the SOM soldered
> > +          on an adapter board or for the connector variant to demonstrate parallel
> > +          display and majority of interfaces while MBa93xxCA starterkit mainboard
> > +          is focused on communication interfaces without display support.
> >          items:
>
> [Severity: Low]
> This isn't a bug, but it looks like the new description block duplicates the
> existing phrasing for the MBa91xxCA board instead of replacing it.
>
> The context above this addition already contains fragments like soldered on an
> adapter board or for the connector variant which seem to originate from the
> older description of the MBa91xxCA board.
>
> Could the previous, redundant sentences describing the MBa91xxCA mainboard be
> removed to avoid duplication in the final schema text?
>
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/20260707091424.1702245-1-alexander.stein@ew.tq-group.com?part=1