From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E68E33D3326 for ; Thu, 9 Jul 2026 08:16:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783584980; cv=none; b=WtSBmxoJz+4TGsS3Ez1Bf0dkhPd7aLjYzoO4DUbw2JhQbowgJlxj2kED7JDGMN4bJ/LHJ5ByKOuSk55a4aM2adtElkgvHOM2gKJT4Az0GNK220U5JOe1FySJgcFC68sNDUx52urH323+PlFORhVv1NlNoA8x3eTRln2gFW+7C7A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783584980; c=relaxed/simple; bh=vMvzVDyhwRVZ9mU/uGek2iqLm5M9Oc3aOzpsUrM1kxM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qzurQCFSM75JUrz3jyTOopi6sXPI1H2TnfQTCnVrnAmoK5KLBg3+jkn0dIpg46hNHCfrFRznEOewZmL3pGvZYcDsvNz5X4b1uJOH/LW9+ys/7Mwb8yvN5ncxnvvc+QJJt5KIkg2oOqVG03OLOZEDoh0/uvSvGKo6SsA5ikKTVLA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=BvFrVRoe; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="BvFrVRoe" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-493e497643fso8555585e9.0 for ; Thu, 09 Jul 2026 01:16:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783584976; x=1784189776; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=z+CFlNGgVOBUKoyPjKhrOhvumBe76lgJlilpAZoLH+g=; b=BvFrVRoeLdX9K67kasMhrWS3/kUZ3sUPj+VTdiYOPJrmUJ2OVcYURmwa5PSTGOl80p EKMqIJlyhLMJIDKcjk/Uupo22TEgpkVnjJ3miA+2E6zuDJECj4soGqwzKsL0HzzQUH4c kmSzGWLSqlgnxW9Kig//yvcbRE58E7qwLWaM70bo6Y8pu6+BQMQtY6J1ytMSDWQIHRYk BhSVn9FzF8ZLqhxyoL+F20K+CvCwkYwbkpIRWa3zP6tf04lYKxrWcOk0koGiilHLjWyh 0/xUZkcbeb1xgpVL7F6EvzAeQHxKAf+g5kby0g8tvIK6H0+8v+A32sHsdg2XmTJ6iuSL jnKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783584976; x=1784189776; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=z+CFlNGgVOBUKoyPjKhrOhvumBe76lgJlilpAZoLH+g=; b=IGfufwtcUlILvgMkNbQQ9bTIKSgxh5TItyK5eyDrTrm+xxpDz9+ZCuKE4dMe4Tvhsh wHkj57GTlvBioH4T0D3153/t0Gw71DkU1RTUN1xGlc+aoyeGOz2IEdTX3UMzg184lthH 8EEuHPgXzLWSzseVfQd07YMo0cl7clvEo00mcLwsht9lGrQ++NO9jEfAk9k88yp7jZ3O ZKny8xQSQ8Un/TNTaY+QqP8QMG30CaxGbwa/64/6yZ7aSu846aBOsnW6l3LUaIkTY19y yt4Q2JmrB8rumAFnDCn5mDWyA6CTpvPCi+PErlOddndMqpYBSfcguveZ66lQkBDR4MI3 QLDg== X-Forwarded-Encrypted: i=1; AHgh+RoXO4HcSNHCBOGyXfBdMXyWLTx38SJ+Hsou2re0Itd8VqoCsfTc92STkWnbo+vylVB7iRohXLGipyzD@vger.kernel.org X-Gm-Message-State: AOJu0YzaGUw0GIXZq7smiOwsBN2L8ZbxfRRUwUyHyPujnEGhjzXhyOAX cPO7tZ4cR4TzlLV99keGhWral2HnUKTaVx2H0KNADKGyndblyzXGjplh19knFqZzwG0= X-Gm-Gg: AfdE7cnUvK3DkFyeGd0lzwnj655UTsyHQs7EDajUppAy/CQVG4Ww8jV5zWgRJyRiFSq i2LWP2kGwrpV6IwW1SuyW1kl78+WS/9V0+i5CXBrewr3FxNwQz3ToGhdS7p7kFTPBWGsxyiwO9N KzNuZ846Lt5BELZI9CcM+mxCVFibHRaylb6I6t+7tGhottrh6egnUYtXPA12uIPoZ2vA1svqS4y 36ujbz51zjjI/9PM2H9QjgG370ET3rA/BtvyvUzq4y6LdNteRV4ylZVAD+Me2pKAdLZTN//7nb/ eGysdDbDTqosPZpP1giWlsBV8xa3Y+6mmcMMKBYqt5HHpn+JnjfcsXw7XiBplWQqQib3Rid5Igs zMHRJ+xdBzHVTQH470FLdJBLQTDfPrK/BFUuAOCXnnMvt6w3oypiqOtvVOP+48Mk9rpSU2mzDhv hyczx7myMy2iae/Os= X-Received: by 2002:a05:600c:1d1e:b0:492:7084:32af with SMTP id 5b1f17b1804b1-493e68bf03amr56205565e9.23.1783584976164; Thu, 09 Jul 2026 01:16:16 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493ee2bcac0sm20177645e9.0.2026.07.09.01.16.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 01:16:15 -0700 (PDT) Date: Thu, 9 Jul 2026 10:16:12 +0200 From: Petr Mladek To: Lorenzo Stoakes Cc: Mukesh Ojha , Jonathan Corbet , Shuah Khan , Eugen Hristev , Arnd Bergmann , Dennis Zhou , Tejun Heo , Christoph Lameter , Andrew Morton , Thomas Gleixner , Peter Zijlstra , Anna-Maria Behnsen , Frederic Weisbecker , John Stultz , Stephen Boyd , Kees Cook , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , David Hildenbrand , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , Youngjun Park , John Ogness , Sergey Senozhatsky , Bjorn Andersson , Mathieu Poirier , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Saravana Kannan , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 21/26] printk: Register information into meminspect Message-ID: References: <20260708-meminspect-v3-v3-0-7aa5a0a74d5c@oss.qualcomm.com> <20260708-meminspect-v3-v3-21-7aa5a0a74d5c@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed 2026-07-08 08:59:26, Lorenzo Stoakes wrote: > On Wed, Jul 08, 2026 at 11:02:00AM +0530, Mukesh Ojha wrote: > > Annotate vital static, dynamic information into meminspect for debugging > > > > Static: > > - prb_descs > > - prb_infos > > - prb > > - prb_data > > - clear_seq > > - printk_rb_static > > - printk_rb_dynamic > > > > Dynamic: > > - new_descs > > - new_infos > > - new_log_buf > > > > --- a/kernel/printk/printk.c > > +++ b/kernel/printk/printk.c > > @@ -49,6 +49,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -518,10 +519,17 @@ static u32 log_buf_len = __LOG_BUF_LEN; > > #endif > > _DEFINE_PRINTKRB(printk_rb_static, CONFIG_LOG_BUF_SHIFT - PRB_AVGBITS, > > PRB_AVGBITS, &__log_buf[0]); > > +MEMINSPECT_NAMED_ENTRY(prb_descs, _printk_rb_static_descs); > > +MEMINSPECT_NAMED_ENTRY(prb_infos, _printk_rb_static_infos); > > +MEMINSPECT_NAMED_ENTRY(prb_data, __log_buf); > > +MEMINSPECT_SIMPLE_ENTRY(printk_rb_static); > > > > static struct printk_ringbuffer printk_rb_dynamic; > > +MEMINSPECT_SIMPLE_ENTRY(printk_rb_dynamic); > > > > struct printk_ringbuffer *prb = &printk_rb_static; > > +MEMINSPECT_SIMPLE_ENTRY(prb); > > +MEMINSPECT_SIMPLE_ENTRY(clear_seq); > > > > /* > > * We cannot access per-CPU data (e.g. per-CPU flush irq_work) before > > @@ -1238,6 +1246,10 @@ void __init setup_log_buf(int early) > > > > local_irq_restore(flags); > > > > + meminspect_lock_register_va(new_log_buf, new_log_buf_len); > > + meminspect_lock_register_va(new_descs, new_descs_size); > > + meminspect_lock_register_va(new_infos, new_infos_size); > > + > > /* > > * Copy any remaining messages that might have appeared from > > * NMI context after copying but before switching to the > > Overall exposing live dynamic printk information to drivers seems unwise, but > not quite as insane as some of the other stuff thus exposed... I agree that we should be careful with exporting symbols. Well, if I get it correctly then at least the printk-related symbols are already exported a similar way using vmcore_info.h API, see log_buf_vmcoreinfo_setup(). Best Regards, Petr