From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Sebastian Reichel <sre@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Souvik Chakravarty <Souvik.Chakravarty@arm.com>,
Bartosz Golaszewski <brgl@kernel.org>,
Sudeep Holla <sudeep.holla@kernel.org>,
devicetree@vger.kernel.org, sashiko-reviews@lists.linux.dev
Subject: Re: [PATCH v22 04/13] firmware: psci: Introduce command-based resets
Date: Tue, 30 Jun 2026 12:04:29 +0200 [thread overview]
Message-ID: <akOUrV5BwU9/PuLJ@lpieralisi> (raw)
In-Reply-To: <c2bb7a24-e1d0-4308-ab53-208901108a5a@oss.qualcomm.com>
On Wed, Jun 24, 2026 at 02:04:54PM +0530, Shivendra Pratap wrote:
>
>
> On 15-05-2026 02:53, sashiko-bot@kernel.org wrote:
> > - [High] The API illegally truncates the 64-bit PSCI SYSTEM_RESET2 cookie parameter to 32 bits, violating the ARM PSCI specification.
>
> Hi Lorenzo,
>
> Was going through this comment. The patch currently uses a 32 bit cookie.
> The spec also talks about "SMC64 - uint64 - cookie". Can you please suggest
> if we should add support for 64 bit cookie here?
I am afraid the bot is right, it is not correct to assume that the
cookie upper 32-bits are always 0 :(
Thanks,
Lorenzo
>
> This will require a re-design for supporting about up-to three 32-bit
> numbers in reboot-mode framework.
>
> thanks,
> Shivendra
next prev parent reply other threads:[~2026-06-30 10:04 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 14:25 [PATCH v22 00/13] Implement PSCI reboot mode driver for PSCI resets Shivendra Pratap
2026-05-14 14:25 ` [PATCH v22 01/13] power: reset: reboot-mode: Remove devres based allocations Shivendra Pratap
2026-05-14 14:25 ` [PATCH v22 02/13] power: reset: reboot-mode: Add support for 64 bit magic Shivendra Pratap
2026-05-14 20:15 ` sashiko-bot
2026-05-14 14:25 ` [PATCH v22 03/13] power: reset: reboot-mode: Add support for predefined reboot modes Shivendra Pratap
2026-05-14 21:09 ` sashiko-bot
2026-05-14 14:25 ` [PATCH v22 04/13] firmware: psci: Introduce command-based resets Shivendra Pratap
2026-05-14 21:23 ` sashiko-bot
2026-06-24 8:34 ` Shivendra Pratap
2026-06-30 10:04 ` Lorenzo Pieralisi [this message]
2026-05-14 14:25 ` [PATCH v22 05/13] mfd: psci-mfd: Add PSCI MFD driver for cpuidle-psci-domain cell Shivendra Pratap
2026-05-14 14:25 ` [PATCH v22 06/13] dt-bindings: arm: Document reboot mode magic Shivendra Pratap
2026-05-14 14:25 ` [PATCH v22 07/13] power: reset: Add psci-reboot-mode driver Shivendra Pratap
2026-05-14 22:49 ` sashiko-bot
2026-05-18 8:58 ` Bartosz Golaszewski
2026-05-18 16:45 ` Shivendra Pratap
2026-05-14 14:25 ` [PATCH v22 08/13] mfd: core: Add firmware-node support to MFD cells Shivendra Pratap
2026-05-14 23:19 ` sashiko-bot
2026-05-18 8:57 ` Bartosz Golaszewski
2026-05-18 16:41 ` Shivendra Pratap
2026-05-20 17:51 ` Shivendra Pratap
2026-05-21 11:26 ` Lee Jones
2026-05-21 12:29 ` Bartosz Golaszewski
2026-05-21 13:24 ` Lee Jones
2026-05-21 13:36 ` Bartosz Golaszewski
2026-05-21 16:27 ` Lee Jones
2026-05-22 9:08 ` Bartosz Golaszewski
2026-05-25 9:34 ` Shivendra Pratap
2026-06-03 18:51 ` Shivendra Pratap
2026-06-11 16:42 ` Lee Jones
2026-06-11 16:44 ` Shivendra Pratap
2026-05-14 14:25 ` [PATCH v22 09/13] mfd: psci-mfd: Add psci-reboot-mode child cell Shivendra Pratap
2026-05-18 8:53 ` Bartosz Golaszewski
2026-05-14 14:25 ` [PATCH v22 10/13] arm64: dts: qcom: Add psci reboot-modes for kodiak boards Shivendra Pratap
2026-05-14 14:25 ` [PATCH v22 11/13] arm64: dts: qcom: Add psci reboot-modes for lemans boards Shivendra Pratap
2026-05-14 14:25 ` [PATCH v22 12/13] arm64: dts: qcom: Add psci reboot-modes for monaco boards Shivendra Pratap
2026-05-15 0:24 ` sashiko-bot
2026-05-14 14:25 ` [PATCH v22 13/13] arm64: dts: qcom: Add psci reboot-modes for talos boards Shivendra Pratap
2026-05-29 13:30 ` [PATCH v22 00/13] Implement PSCI reboot mode driver for PSCI resets Shivendra Pratap
2026-06-17 17:00 ` Shivendra Pratap
2026-06-19 15:46 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akOUrV5BwU9/PuLJ@lpieralisi \
--to=lpieralisi@kernel.org \
--cc=Souvik.Chakravarty@arm.com \
--cc=arnd@arndb.de \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shivendra.pratap@oss.qualcomm.com \
--cc=sre@kernel.org \
--cc=sudeep.holla@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox