Devicetree
 help / color / mirror / Atom feed
From: Monish Chunara <monish.chunara@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Manivannan Sadhasivam <mani@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Sarthak Garg <sarthak.garg@oss.qualcomm.com>,
	Pradeep Pragallapati <pradeep.pragallapati@oss.qualcomm.com>,
	Nitin Rawat <nitin.rawat@oss.qualcomm.com>,
	Shiraz Hashim <shiraz.hashim@oss.qualcomm.com>
Subject: Re: [PATCH V2 1/3] arm64: dts: qcom: monaco: Move eMMC CQE support from SoC to board DT
Date: Wed, 1 Jul 2026 13:53:40 +0530	[thread overview]
Message-ID: <akTOjCDcQVLHOUxB@hu-mchunara-hyd.qualcomm.com> (raw)
In-Reply-To: <e6aa773c-daa2-43d4-ac56-4a26c58a3910@oss.qualcomm.com>

On Wed, Jun 17, 2026 at 12:17:28PM +0200, Konrad Dybcio wrote:
> On 6/16/26 3:03 PM, Monish Chunara wrote:
> > The Monaco SoC SDHC controller supports both eMMC and SD cards. However,
> > the 'supports-cqe' property (Command Queue Engine) is specific to eMMC
> > and conflicts with SD card operation.
> > 
> > Remove 'supports-cqe' from the SoC device tree to ensure compatibility
> > with SD cards. Simultaneously, add the property explicitly to the
> > qcs8300-ride board device tree, as this board uses the controller in
> > eMMC mode.
> > 
> > This ensures the SoC definition remains generic while enabling features
> > correctly at the board level.
> > 
> > Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
> > ---
> >  arch/arm64/boot/dts/qcom/monaco.dtsi      | 1 -
> >  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 1 +
> 
> Please also fix up monaco-monza-som.dtsi
>

Sure, updated in v3: https://lore.kernel.org/all/20260701081715.2580329-1-monish.chunara@oss.qualcomm.com/

Regards,
Monish 

  reply	other threads:[~2026-07-01  8:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-16 13:03 [PATCH V2 0/3] arm64: dts: qcom: Monaco: Enable SDHCI storage support Monish Chunara
2026-06-16 13:03 ` [PATCH V2 1/3] arm64: dts: qcom: monaco: Move eMMC CQE support from SoC to board DT Monish Chunara
2026-06-16 13:14   ` sashiko-bot
2026-07-01  8:29     ` Monish Chunara
2026-06-17 10:17   ` Konrad Dybcio
2026-07-01  8:23     ` Monish Chunara [this message]
2026-06-16 13:03 ` [PATCH V2 2/3] arm64: dts: qcom: monaco-evk: Enable SDHCI for SD Card via overlay Monish Chunara
2026-06-16 13:15   ` sashiko-bot
2026-06-16 13:03 ` [PATCH V2 3/3] arm64: dts: qcom: monaco-evk: Add SDHCI support for eMMC " Monish Chunara
2026-06-16 13:13   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akTOjCDcQVLHOUxB@hu-mchunara-hyd.qualcomm.com \
    --to=monish.chunara@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=nitin.rawat@oss.qualcomm.com \
    --cc=pradeep.pragallapati@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sarthak.garg@oss.qualcomm.com \
    --cc=shiraz.hashim@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox