Devicetree
 help / color / mirror / Atom feed
From: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: ipq5210: Enable PCIe support
Date: Tue, 7 Jul 2026 11:40:39 +0530	[thread overview]
Message-ID: <akyYX9XsFTOfuzyQ@hu-varada-blr.qualcomm.com> (raw)
In-Reply-To: <dc7cb371-e94e-4f42-87d6-70f0f94d0d49@oss.qualcomm.com>

Konrad,

[ . . . ]
> > +			assigned-clocks = <&gcc GCC_PCIE0_AUX_CLK>;
> > +			assigned-clock-rates = <20000000>;
>
> Is this clock supposed to be fixed at that rate, regardless of the link
> speed? And is the default rate incorrect?

Yes. The default rate is at xo, so need this.

Have addressed the other comments and posted DTS update patch enabling
multiple devices. Please review [1].

1 - https://lore.kernel.org/linux-arm-msm/20260707-08-dts-v1-0-fce82e14cd1d@oss.qualcomm.com/

Thanks
Varada

      parent reply	other threads:[~2026-07-07  6:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14  4:13 [PATCH 0/2] Enable PCIe controllers present in Qualcomm ipq5210 Varadarajan Narayanan
2026-05-14  4:13 ` [PATCH 1/2] dt-bindings: PCI: qcom,pcie-ipq9574: Document the ipq5210 pcie controller Varadarajan Narayanan
2026-05-15 10:55   ` Krzysztof Kozlowski
2026-05-14  4:13 ` [PATCH 2/2] arm64: dts: qcom: ipq5210: Enable PCIe support Varadarajan Narayanan
2026-05-14 12:33   ` sashiko-bot
2026-05-19 16:57   ` Manivannan Sadhasivam
2026-05-22 12:24   ` Konrad Dybcio
2026-06-04 11:28     ` Varadarajan Narayanan
2026-06-08  9:44       ` Konrad Dybcio
2026-06-09  7:52         ` Varadarajan Narayanan
2026-06-17 10:47           ` Konrad Dybcio
2026-07-07  6:10     ` Varadarajan Narayanan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akyYX9XsFTOfuzyQ@hu-varada-blr.qualcomm.com \
    --to=varadarajan.narayanan@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox