From: Frank Li <Frank.li@oss.nxp.com>
To: Shubham Patil <shubhamsanjay.patil@amd.com>
Cc: alexandre.belloni@bootlin.com, Frank.Li@nxp.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, michal.simek@amd.com,
radhey.shyam.pandey@amd.com
Subject: Re: [PATCH v2 2/2] i3c: master: dw: Drop redundant core reset name
Date: Mon, 20 Jul 2026 11:43:15 -0400 [thread overview]
Message-ID: <al5CExDODceH9mt4@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260720073510.1869623-3-shubhamsanjay.patil@amd.com>
On Mon, Jul 20, 2026 at 01:05:10PM +0530, Shubham Patil wrote:
> The DesignWare I3C master has a single reset line, so a dedicated
> reset name is redundant. Look up the reset by index by passing NULL
> instead of the "core_rst" name.
>
> Signed-off-by: Shubham Patil <shubhamsanjay.patil@amd.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/i3c/master/dw-i3c-master.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index 2f8c0c4683e0..488fb455d3cc 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -1584,7 +1584,7 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
> return PTR_ERR(master->pclk);
>
> master->core_rst = devm_reset_control_get_optional_exclusive_deasserted(&pdev->dev,
> - "core_rst");
> + NULL);
> if (IS_ERR(master->core_rst))
> return PTR_ERR(master->core_rst);
>
> --
> 2.34.1
>
prev parent reply other threads:[~2026-07-20 15:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 7:35 [PATCH v2 0/2] i3c: dw: Document optional core reset and drop redundant name Shubham Patil
2026-07-20 7:35 ` [PATCH v2 1/2] dt-bindings: i3c: dw: Document missing optional core reset Shubham Patil
2026-07-20 7:42 ` Pandey, Radhey Shyam
2026-07-20 7:43 ` sashiko-bot
2026-07-20 15:42 ` Frank Li
2026-07-20 7:35 ` [PATCH v2 2/2] i3c: master: dw: Drop redundant core reset name Shubham Patil
2026-07-20 7:41 ` Pandey, Radhey Shyam
2026-07-20 7:45 ` sashiko-bot
2026-07-20 15:43 ` Frank Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al5CExDODceH9mt4@lizhi-Precision-Tower-5810 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=robh@kernel.org \
--cc=shubhamsanjay.patil@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox