Re: [PATCH v8 1/1] arm64: dts: add tqma9596la-mba95xxca

[Frank Li <Frank.li@oss.nxp.com>]

On Tue, Jul 14, 2026 at 03:01:25PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] Unreferenced 10G SFP regulator will be unconditionally disabled by the regulator core.
> --
>
> --- Patch [1]: [PATCH v8 1/1] arm64: dts: add tqma9596la-mba95xxca ---
> commit b7aa596cf679be039938abc33965834ed28f5c60
> Author: Markus Niebel <Markus.Niebel@ew.tq-group.com>
>
> arm64: dts: add tqma9596la-mba95xxca
>
> This adds support for TQMa95xxLA modules, designed to be soldered
> on a carrier board. MBa95xxCA is a carrier reference board / starter kit
> design.
>
> > diff --git a/arch/arm64/boot/dts/freescale/imx95-tqma9596la-mba95xxca.dts b/arch/arm64/boot/dts/freescale/imx95-tqma9596la-mba95xxca.dts
> > new file mode 100644
> > index 0000000000000..1d745d66997cb
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx95-tqma9596la-mba95xxca.dts
>
> [ ... ]
>
> > +	reg_3v3a_10g: regulator-3v3a-10g {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "3V3A_10G";
> > +		regulator-min-microvolt = <3300000>;
> > +		regulator-max-microvolt = <3300000>;
> > +		gpio = <&expander2 15 GPIO_ACTIVE_HIGH>;
> > +		startup-delay-us = <2000>;
> > +		enable-active-high;
> > +	};
>
> [ ... ]
>
> > +	sfp_xfi: sfp-xfi {
> > +		compatible = "sff,sfp";
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_sfp>;
> > +		i2c-bus = <&lpi2c7>;
> > +		maximum-power-milliwatt = <2000>;
> > +		mod-def0-gpios = <&expander1 3 GPIO_ACTIVE_LOW>;
> > +		tx-fault-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>;
> > +		los-gpios = <&gpio2 31 GPIO_ACTIVE_HIGH>;
> > +		tx-disable-gpios = <&expander2 2 GPIO_ACTIVE_HIGH>;
> > +	};
>
> [Severity: Medium]
> Will the 10G SFP regulator be turned off by the regulator core?
>
> The reg_3v3a_10g regulator is defined without regulator-always-on, and the
> sfp_xfi node seems to be missing the vcc-supply = <&reg_3v3a_10g>; property
> to link the SFP to its power source.
>
> Since it lacks consumers, won't the regulator core automatically disable this
> unused regulator at the end of boot and unconditionally turn off power to the
> 10G interface?

Is it true?

Frank
>
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/20260714143154.787825-1-alexander.stein@ew.tq-group.com?part=1