From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC2EA418A48 for ; Tue, 21 Jul 2026 21:45:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784670313; cv=none; b=dK70EshcgRvtN7FLq4JL7XoG3hoUZihZ5Kj00ZNDSQr5hj3iZhaEdPbs2QO2C8dUwOdVQxW6sUnpu38+2Q1RYDvxwsHPXp5MFRnkXNukhlUigCC2MTonjm1nC58lFnknosrrqbY4S36osdHG6THuT8CWuUzLiBLhxqBk6jXvJcI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784670313; c=relaxed/simple; bh=P4vEW4E97s/Whcgqzj22YJd6YtHWK8jwLYQ5yOODq4Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sxsR+LH3u4f4KRK8T8OCBZ1SZl6OqhKkFRykLVnZZA5pBOVp7clPScfQBGBrD9utHc0f918a+lWZbZAWS52eIPQivCLysHxTJZBfbFVyw51asnhSJL5OPHM5XstdYWJr+9jZqKiBxhz6JTN+JhBUayd3773Tvv1sbGYxKY4Lc1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ysx/c8WK; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=I9Bnz9bp; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ysx/c8WK"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="I9Bnz9bp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784670310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CzmiG2Js6lBhSRfjmB0Juw8EH5EE62nACbevKWRU0bs=; b=Ysx/c8WKUBomb6FHvx6BSVjU816oOk39pvikopbS/bS9Uq7IQswCxNRV2gznXEegCw6rJP C9HM/ucYJbRiAm9PY0/FTQb7Dy4ja/e90H89upwt8/T2O7yBwNOpszWlZdM5wR4I6ds1J3 n96JUjmdxxblVpfFDH7FmWzFPEzEDc8= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-540-Ji3kylNKM8C9Lo_nJyi6QQ-1; Tue, 21 Jul 2026 17:45:09 -0400 X-MC-Unique: Ji3kylNKM8C9Lo_nJyi6QQ-1 X-Mimecast-MFC-AGG-ID: Ji3kylNKM8C9Lo_nJyi6QQ_1784670309 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e8004d60eso1871159685a.1 for ; Tue, 21 Jul 2026 14:45:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784670309; x=1785275109; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=CzmiG2Js6lBhSRfjmB0Juw8EH5EE62nACbevKWRU0bs=; b=I9Bnz9bpOO/NU+Hl305x6+bg7nGZyhweEkH4XEsz7qqNpINXQ7ONU3wo2sP1cqdpLJ wKgIIz/a6n4EIin+cHdD8h72Ad62rwL5P4h6bZFEaHuqvk3r/dllgD3VUtSCdhsZCc5l nCKwgKE1o15Il8IKrf7oDEY/RhU+lAscD0GkfaUNXPjob449BSKXHIFDD2iIysOL/gXs l7PScho2yXkXCNQ2SqaqdBCN7YoztxohSFqwU6PMPA1DItQPHPHzvtRAmt+plW/ODXwd nW6qaDR3IF52PZB3Lf6V35q0Zk4PvBAiEbla/1wDrOLqhUIOhn+jvfPO1A8BprO202V0 DedA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784670309; x=1785275109; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CzmiG2Js6lBhSRfjmB0Juw8EH5EE62nACbevKWRU0bs=; b=jaLZlrU9DSIE8pP2mSXVi9cGiyL/9wxGU1xR3ElM+HEX3vJOuacQUyw4PqhkLXT7yQ /wEPzDITPHXPhFp1RT9jPxAcnZFgNl+lD3IaplJ6TgrH+RAHRuDvE4KFvJeOur7XGnur alu575lSSGzAjCWM/hTdhHfK5EZMHz64iCHqxt/5AvPDWYKfqZt5s24khAFXqf5FnkKc ukU5bTSomLyFc6KWI3n+kPV/eF8kRvMOYNEhHioM669F40efG4mpcMlgJLBzSbFom9Lk SbdBeczi9Mk/kOBxIr4HDIApXLM15GSvYTJr74WqsSToQ1JRUQ/4Yerxm0za5aMAT22j 3olg== X-Forwarded-Encrypted: i=1; AHgh+RrhAloXSjUQ1hLoR/tbMc3Ym5lJuV3RTxJ02HJaW9LB5KgXGj6O1uuDraOBogsrD8LaCA/q9rGeq4ql@vger.kernel.org X-Gm-Message-State: AOJu0YxskVlGwskiqdoPSWuIaDB4ek1maptxO6YqCvhszKc0Ociq/+zD iPHYd+LF3o4xP7AzRjUhlKkO6tlTFJerR+TxA3fxAi3Zhjsidnz1tOj98Ww1LUscu+eUkLp8my4 K9wVixWfUZQG1EJuCfHfXyJwQ5gO3MSXJ32rApckBcGf19jCchflza4BOx9sqZUY= X-Gm-Gg: AfdE7cmHBBnVBZvFw7jko3tFYApn/srjR+ef3qZNhFameYuzGlpFsWlUd8LQIpuuDHi dHQ/8czr4Ws5ppLcdSY01LWT2JfDdAKMJVg2fYVSbg8TfJ+P67d5VPS4L0NT01CLWEz0EWTd7rC IruR7yhCdc3m0mgLBPMAxt1Mz1xJsDwNtyZKO0nJI31s06B3RF+wb62AvQvbiy1zWmKHfS6ylK1 NFd4Wn7cqPxsZTh9/2Y+PV4RG2shpS1aCYy6BIJClN2EuCdOnazGLsoQOshw8RPrv5uoTbFcyS6 UfajjoMKD9O9C/nyNJ6aGPO9lNo+uND9pk3jw1P1OVtXDWjdBegj2x89dnvaNM766ztRq2CXKU1 9SEfh2xcICledY7U2onpwSG9AoivLEcloez4= X-Received: by 2002:a05:620a:6287:b0:92e:44be:bbd2 with SMTP id af79cd13be357-930b3e6fa07mr2011533885a.9.1784670308827; Tue, 21 Jul 2026 14:45:08 -0700 (PDT) X-Received: by 2002:a05:620a:6287:b0:92e:44be:bbd2 with SMTP id af79cd13be357-930b3e6fa07mr2011529885a.9.1784670308359; Tue, 21 Jul 2026 14:45:08 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id af79cd13be357-930b52df3f9sm1222910785a.8.2026.07.21.14.45.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 14:45:07 -0700 (PDT) Date: Tue, 21 Jul 2026 17:45:05 -0400 From: Brian Masney To: wangjia@ultrarisc.com Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Conor Dooley Subject: Re: [PATCH v4 0/3] clk: ultrarisc: add DP1000 clock support Message-ID: References: <20260720-ultrarisc-clock-v4-0-fe639d63bbac@ultrarisc.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260720-ultrarisc-clock-v4-0-fe639d63bbac@ultrarisc.com> User-Agent: Mutt/2.4.0 (2026-06-19) Hi Jia, On Mon, Jul 20, 2026 at 08:38:03AM +0800, Jia Wang via B4 Relay wrote: > This series exports a small common clock helper and adds the devicetree > binding and clock driver for the UltraRISC DP1000 SoC. > > The clock tree is driven by a SYSPLL and provides fixed-factor clocks for > the subsystem and PCIe, divider-based root clocks for GMAC and the UART, > I2C, and SPI blocks, and per-instance gate clocks for UART0-3, I2C0-3, > and SPI0-1. > > Testing: > - dt_binding_check and dtbs_check on ultrarisc,dp1000-clk > - Kernel build for RISC-V and boot-tested on DP1000 > - Modules build test for CLK_ULTRARISC_DP1000 > > Signed-off-by: Jia Wang > --- > Changes in v4: > - Drop the initial clk_hw_get_rate() max-rate warning after setting the > divider rate range. I also see this in the diff between v3 and v4. Is this expected? +++ b/drivers/clk/ultrarisc/clk-dp1000.c @@ -0,0 +1,154 @@ @@ -309,8 +309,8 @@ + .frac_mask = GENMASK(23, 0), + .m_mask = GENMASK(23, 16), + .n_mask = GENMASK(11, 6), -+ .oddiv1_mask = GENMASK(4, 3), -+ .oddiv2_mask = GENMASK(1, 0), ++ .oddiv1_mask = GENMASK(1, 0), ++ .oddiv2_mask = GENMASK(4, 3), Brian