From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Lechner <dlechner@baylibre.com>
Cc: Jakub Szczudlo <jakubszczudlo40@gmail.com>,
linux-iio@vger.kernel.org, jic23@kernel.org, nuno.sa@analog.com,
andy@kernel.org, marcelo.schmitt@analog.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, mike.looijmans@topic.nl,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
jorge.marques@analog.com, antoniu.miclaus@analog.com,
mazziesaccount@gmail.com, jishnu.prakash@oss.qualcomm.com,
duje@dujemihanovic.xyz, wens@kernel.org,
sakari.ailus@linux.intel.com, linusw@kernel.org
Subject: Re: [PATCH v7 0/3] iio: adc: ti-ads1100: Add support for TI ADS1110 to ti-ads1100 driver
Date: Wed, 15 Jul 2026 09:46:38 +0300 [thread overview]
Message-ID: <alcszm5-9alInIo0@ashevche-desk.local> (raw)
In-Reply-To: <66b7b01f-0e79-4387-9b68-92858ccc1fe7@baylibre.com>
On Tue, Jul 14, 2026 at 03:20:18PM -0500, David Lechner wrote:
> On 7/14/26 2:55 PM, Jakub Szczudlo wrote:
> > Add support for the TI ADS1110 to the existing ADS1100 ADC IIO driver.
> > The ADS1110 is pin-to-pin compatible with the ADS1100 while providing
> > higher resolution and an internal voltage reference. This patch series
> > extends driver support for ADS1110, updates device tree bindings and
> > Kconfig text, and improves the overall hardware description for the
> > TI ADS1100 family.
> >
> > Tested on: Raspberry pi 3b+ with 7.0 stable kernel
>
> Hopefully this applies on the iio/testing branch? A lot could have changed
> since 7.0.
> > ---
> I made some suggestions for cosmetic improvements, but good enough for
>
> Reviewed-by: David Lechner <dlechner@baylibre.com>
+1 here, but I think the chip_info naming and actually -ENODATA are good to be
in from day 1. Assuming that is going to be addressed in v8,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-07-15 6:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 19:55 [PATCH v7 0/3] iio: adc: ti-ads1100: Add support for TI ADS1110 to ti-ads1100 driver Jakub Szczudlo
2026-07-14 19:55 ` [PATCH v7 1/3] iio: adc: ti-ads1100: Fix incorrect reading when datarate changed in single mode Jakub Szczudlo
2026-07-14 20:10 ` sashiko-bot
2026-07-15 6:45 ` Andy Shevchenko
2026-07-14 19:55 ` [PATCH v7 2/3] dt-bindings: iio: adc: ti,ads1100: add support for ADS1110 Jakub Szczudlo
2026-07-14 20:04 ` sashiko-bot
2026-07-14 19:55 ` [PATCH v7 3/3] iio: adc: ti-ads1100: Add ti-ads1110 support to ti-ads1100 driver Jakub Szczudlo
2026-07-14 20:07 ` sashiko-bot
2026-07-14 20:18 ` David Lechner
2026-07-15 6:42 ` Andy Shevchenko
2026-07-14 20:20 ` [PATCH v7 0/3] iio: adc: ti-ads1100: Add support for TI ADS1110 " David Lechner
2026-07-15 6:46 ` Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-07-14 19:47 Jakub Szczudlo
2026-07-14 19:58 ` Jakub Szczudło
2026-07-14 20:04 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alcszm5-9alInIo0@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=duje@dujemihanovic.xyz \
--cc=jakubszczudlo40@gmail.com \
--cc=jic23@kernel.org \
--cc=jishnu.prakash@oss.qualcomm.com \
--cc=jorge.marques@analog.com \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=mazziesaccount@gmail.com \
--cc=mike.looijmans@topic.nl \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox