Re: [PATCH v4 4/6] arm64: dts: imx8mm: imx8mp: Add CM DTOs for Data Modul i.MX8M Mini and Plus eDM SBC

[Frank Li <Frank.li@oss.nxp.com>]

On Wed, Jul 15, 2026 at 06:38:32PM +0200, Marek Vasut wrote:
> On 7/15/26 6:22 PM, Frank Li wrote:
>
> Hello Frank,
>
> > > > > > > [Severity: Medium]
> > > > > > > Will this node name bypass the driver's carveout exclusion logic?
> > > > > > >
> > > > > > > Looking at imx_rproc_prepare(), it iterates over memory-regions and checks
> > > > > > > specifically for the name "vdev0buffer" to skip processing the vdev buffer:
> > > > > > >
...
> > >
> > > never existed in imx_rproc.c:
> >
> > AI refer old version code, but problem is the same
>
> No, sorry, the aforementioned piece of code never existed in imx_rproc.c
> according to git log. There is no old version of the code that looked
> anything like what the AI produced above.
>
> > if (strstarts(res.name, "vdev0buffer"))
> >
> > >
> > > "
> > > $ git log --follow -p next/master -- drivers/remoteproc/imx_rproc.c | grep
> > > vdev0vring1
> >    ^^^^^^^^^^
> >
> > vdev0buffer
>
> The AI generated review content above does refer to vdev0vring1 , which is a

No, AI talk about "vdev0buffer" at beginning, never said vdev0vring1 at all.

"   Looking at imx_rproc_prepare(), it iterates over memory-regions and checks
   specifically for the name "vdev0buffer" to skip processing the vdev buffer:
"

> unique identifier, but that unique identifier exists only once is the entire
> history of drivers/remoteproc/imx_rproc.c and that is as a code comment .
> That proves my point that the aforementioned AI generated review feedback is
> not based on code that ever existed in the kernel.
>
> > >      vdev regions are vdev0vring0, vdev0vring1, vdevbuffer and similar.
> > > "
> > >
> > > It seems the AI hallucinated something which is not based in reality ?
> >
> > git log --follow -p linux-next/master -- drivers/remoteproc/imx_rproc.c | grep vdev0buffer
> > -		if (!strcmp(it.node->name, "vdev0buffer"))
> > +		if (strstarts(res.name, "vdev0buffer"))
>
> "
> if (strstarts(res.name, "vdev0buffer"))
> "
>
> and
>
> "
> 	    strstarts(res.name, "vdev0buffer"))
> "
>
> looks like different code , and the AI reported "strstarts(res.name,
> "vdev0buffer"))" which never existed in drivers/remoteproc/imx_rproc.c as is
> clearly visible from the command output you shared above.
>
> So, what exactly is the problem here , can you please clarify it without
> referencing the AI generated content above ?

The problem is simple, node name should use

	vdevbuffer: vdev0buffer@b8400000
                        ^

Frank

>
> Thank you for your help !