From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 516753D2FFC for ; Thu, 16 Jul 2026 10:37:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784198265; cv=none; b=VPyvoY1vKbOTr+yNPWaD9VS7vdO9nocbUEApIz1FRffE/y/QYSAedcgbI91YOoGPWZd8GlAsSAnyx2ZPqsXc6FeNn01A6IOp4vqXOh1R8QHtLg2hZhO53Yr5AkNPI2eryPyMvEbHDiXVKdgVP6K+8Vx9pimSEAApl8GjWg0n9DM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784198265; c=relaxed/simple; bh=THZ6Dm90Uo5++KFw2Oyy1EP/2IUaW1myPl82jpCEWKw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HE4wnQh2WZMPtTWd+N5I/oo30Bgf0brHdbih37L1rRl4QlEI408xmbrD5g5o9Y5DI+xZQjDNPY9hubvcATJuV3QgJSJxi48YiuTFyudygiMA9l4sPky+En4Bmp+4CacJ+3EqA81dV6sOoll7qscmN4T0AlmBnBHr+NtGRNuT29g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ds1VxlCW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=N1MJCY1y; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ds1VxlCW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="N1MJCY1y" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66G9rGeK2471860 for ; Thu, 16 Jul 2026 10:37:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=Lk6h7nzCt6VjsgsfBseF8awD CLuqhyostmxHjxtpO/8=; b=Ds1VxlCWnV1p72FNQO5Okm5GxczgITU5w7eRiOwh zL6/1HoGDSPHMk11olZFZG0HIyP5UlySaCnFBhv/X/m71f6q5dDzMZaWD64uDir1 gYRMluOeCxF6ULpMxJZli0A0DFOR+JqDPM393xsKarvcCN7aZOUE9nkMaOcvVcP8 OlaskskdFnHg0nDzZxH9xpTML9iQh0MVIf0IYAfw5y3iVd/5abtTyKqGe/C1Ql/U hkUa27SOYYFM2EKVuisuLK9+CJH69NKEHQU5F3PWq9wUHfpZaL0b2KYmaJvF7fI4 b0QdiXDUZl1h/80YP3ifFV4rBzGGfMqYxzNUnnz7Yz6HmQ== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fen4w9ysp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Jul 2026 10:37:43 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-8484f26852dso3291594b3a.1 for ; Thu, 16 Jul 2026 03:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784198263; x=1784803063; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Lk6h7nzCt6VjsgsfBseF8awDCLuqhyostmxHjxtpO/8=; b=N1MJCY1yTVBNsDzJeq46jp3ASG6B1yQizm0olVb0PsKG3Wqa0XQRAvXkVv4poIXMmZ SL84XjPxDeEiSM63byp+CWA2l407OLHcUncNPlKNK8hJJ8okVV498exXyHLdbvLo+rrG nKgiRWXtOcpsPNcmhDZMzbuR121HTr7SG/zqHRramLlDGSPopwtZC90xFJc+SYCVdybz ViMHZnigN/hSTOuULcSIvHFw4TmfV6xv5Tz282LESP1yNfXNepvc3qa7/nQ1us6WFfn4 NoUFZ0oBTjl43haX0/9RNqJC3oPo9Vc0NcIjw9/TumVvYaLTZa3+aLeULNPhfUEy91/U slOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784198263; x=1784803063; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Lk6h7nzCt6VjsgsfBseF8awDCLuqhyostmxHjxtpO/8=; b=kYrAeI7AIhOqjh0p9vxToPcn5t3DvCwhZNcukYgoPt41zURvzP/0euZdf7KatDMktY QZIMAiFjcXc1z1Ce40yDDVpmUlkQ4z4kyGA/WsLzKYheT/gxCkD5wgCzt8CzNjfprZUI EXfYzv8c/GXsoouo8/lNBvlZM23gerlQxgP7DXQvAdVkOxzE+IERITIK8slPyiq9tSFn QPXtlkdC5BiklXVmJrpnyDwjmb3Q5pMFnQ5xDkn3EAWLxDthc1FNAMYXa2wtgA6vm8TR wTYpUlQdctC50PnvfcNhQMWrV5K5ODEZJy9IPAoyyz3oByv0CdN3ng3qQcFwNbM2HNfY yiog== X-Forwarded-Encrypted: i=1; AHgh+RrGmK89zmHu5wkyeGttaKMYJTM8qd5YtUtAg8ISPoUIbxpaASOngbnicG93DIwlU6Bqr55R7M+J2i3v@vger.kernel.org X-Gm-Message-State: AOJu0Yx83gBn03+d9Zj/RwvbsodDT0oP5ZMhSHx1pMd48lbKr4XpT42S oimnKHloRJkDnSiYYjkFg++G16RhgjnvtOAgAa5ZAoOPon+z9qKdaXNUbAuBbvXQmLtEzQjZeqI QWokGdwfpBmsLwXpJqCoFxghcTbWV/0CxMb594Gwn/StsG8BZu+a7LCjPu3bx0Q0m X-Gm-Gg: AfdE7ckbS9/HUkw7Kyo4Koq124NdEA1ZrUKm1d99G8gO0NhQf/zIif7lUUK91B7tEb1 EMryOgekqCpAFYRlsq1j004COCPbrd9MpW0ysaEAAbKPU+Ej0w7kyCz81Fp4+Btb+PzK5T0JnWs YNOnblaM7ph2U2VBvRxBbfHmrgx8nwITsiFVOUt6wNBp+MExIJPS9v2pBGt9WqWHgetZy9nWlOx ExgyfZ6BIAU5i/MHnImMUFVnbTJLOr4vZJAeJ8LUqm0kZfl52csHDbFm4NgiNP/tpc7zI+awvIq ih51BPMQZJmbTQZ0H+8jEfHYwiv45nMeyWT7Jl3RB2Hgg+oJXEjyGdoIrRg1HXrB4kG2fqR7N1A cL46nbs3SgT43KemeCe90eKP5v2/J2DU3VLH4cAfNW6pZoXvQOA== X-Received: by 2002:a05:6a21:4c13:b0:3c3:928a:b0c1 with SMTP id adf61e73a8af0-3c3928ab1d2mr1591976637.74.1784198262870; Thu, 16 Jul 2026 03:37:42 -0700 (PDT) X-Received: by 2002:a05:6a21:4c13:b0:3c3:928a:b0c1 with SMTP id adf61e73a8af0-3c3928ab1d2mr1591945637.74.1784198262413; Thu, 16 Jul 2026 03:37:42 -0700 (PDT) Received: from hu-petche-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13cdc4accf4sm1387292c88.10.2026.07.16.03.37.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 03:37:42 -0700 (PDT) Date: Thu, 16 Jul 2026 03:37:40 -0700 From: Peter Chen To: Krishna Kurapati Cc: Thinh Nguyen , Krzysztof Kozlowski , Dmitry Baryshkov , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , "linux-arm-msm@vger.kernel.org" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 1/2] dt-bindings: qcom,snps-dwc3: Add property indicating presence of eUSB2 phy Message-ID: References: <7a099224-ea95-40ec-b279-f8834f261e23@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Authority-Analysis: v=2.4 cv=PsejqQM3 c=1 sm=1 tr=0 ts=6a58b477 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=pkNXjn1FWkeuvB4ljW0A:9 a=CjuIK1q_8ugA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-GUID: iTK1beguHeu6SQwTP1oi8DPbdkIHvXAV X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE2MDEwOCBTYWx0ZWRfXzL0RnvLbt7y7 67P3AN8gs5Wjz79yNxsH53/Da3YjfNMfZox4oRaoWz4i5cHPH1QbnEKwHgV2lOlXdOJS8k0fOWe xxO6XgSRbB8ZWV5vEgW4kHJTmIL4aMc= X-Proofpoint-ORIG-GUID: iTK1beguHeu6SQwTP1oi8DPbdkIHvXAV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE2MDEwOCBTYWx0ZWRfX0sxWc1eXIt0g /tqa5/OUmDiD2EboPBP4wowPpo1fd20PdE9VSc0V/lv5kb278qe2ClrzJNewhEKTC3niMVrZNok GodAsH+YXcFRPmQy0rfbaZaJYrmbjkvC5pbl+CehpYZm35ZDs9mwLr8mkHKKAN0NizLhnEqNoRa y31v28jcEk+N04Nn7hzISnMiJ4SO70qwjSxJdyqFXR8kKtDIVVsKCPSHjs8/e+5RPZujcZA4W03 HNsftIaV85CmpAD7+8c3fW70E242rsAaXsnHKxP2SUiohdcYNe7E7UYBpBmdJF9ENdc/tMsKKIU ow1n1r4WeryTLuHG5qp1A5lodhAt7CpVDIg9eHW0YrGzOP2X3maX/GCzU1EOe4Ozrwxh70AKDNh 0YfwqCnhaHyoh2XN0+xfnTQ6x4ySdGBmkHMZjUqR2ad+mokCSebl6onGVpI7/GU3Qd3DyWNzPYQ srsWzRkuGdKIDRao9pg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-16_04,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 clxscore=1015 bulkscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607160108 On 26-07-16 09:42:35, Krishna Kurapati wrote: > > > > > > At minimum, dwc3 needs to be reviewed and updated for dwc->hsphy_mode > > check when configuring GUSB2PHYCFG. Regardless, phy type should not be a > > usbphy_modes enum as I noted above. > > > We can just add the enum for eusb2 in of.c as pointed by Peter in [1], read > that in dwc3-qcom.c and use it during suspend resume for interrupt handling > and to modify the DWC3_GUSB2PHYCFG_EUSB2OPMODE bit once we are modifying it > in core. > I have seen fewer platforms use "phy_type" at dts for arm64, dwc3 core uses it only for special cases and the code was added for ten years ago. For the default situation, we may not need to change DWC3_GUSB2PHYCFG_EUSB2OPMODE value for UTMI+, Thinh, is it correct? -- Thanks, Peter Chen