From: Drew Fustini <fustini@kernel.org>
To: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Cc: Guo Ren <guoren@kernel.org>, Fu Wei <wefu@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, MoeLeak <i@leak.moe>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Icenowy Zheng <uwu@icenowy.me>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>
Subject: Re: [PATCH v2 4/5] riscv: dts: thead: Add IO labels for the IO expansion on I2C1
Date: Thu, 16 Jul 2026 13:52:19 -0700 [thread overview]
Message-ID: <allEg/A+Gt/em0Hs@x1> (raw)
In-Reply-To: <20260714074515.1959352-5-zhengxingda@iscas.ac.cn>
On Tue, Jul 14, 2026 at 03:45:14PM +0800, Icenowy Zheng wrote:
> From: Emil Renner Berthing <emil.renner.berthing@canonical.com>
>
> Add labels for GPIOs on the IO expansion chip on the I2C1 bus.
>
> Signed-off-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
> [Icenowy: Splitted off the patch adding all 3 IO expansions]
> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> ---
> arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts b/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
> index 74b120c6b063a..78f5979a56c14 100644
> --- a/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
> +++ b/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
> @@ -128,6 +128,14 @@ ioexp2: gpio@18 {
> reg = <0x18>;
> gpio-controller;
> #gpio-cells = <2>;
> + gpio-line-names = "",
> + "cam0_reset",
> + "cam1_reset",
> + "cam2_reset",
> + "wl_host_wake",
I am not sure the line name really matters all that, but it seems that
pin 4 is also used as a reset gpio:
wifi_pwrseq: wifi-pwrseq {
compatible = "mmc-pwrseq-simple";
reset-gpios = <&ioexp2 4 GPIO_ACTIVE_LOW>;
post-power-on-delay-ms = <200>;
};
Did you notice that too?
Thanks,
Drew
next prev parent reply other threads:[~2026-07-16 20:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 7:45 [PATCH v2 0/5] Add remaining IO expansions on Lichee Pi 4A Icenowy Zheng
2026-07-14 7:45 ` [PATCH v2 1/5] riscv: dts: thead: th1520: remove pclk for I2C1 Icenowy Zheng
2026-07-14 7:45 ` [PATCH v2 2/5] riscv: dts: thead: Add TH1520 I2C nodes Icenowy Zheng
2026-07-14 7:45 ` [PATCH v2 3/5] riscv: dts: thead: lpi4a: sort nodes Icenowy Zheng
2026-07-14 7:45 ` [PATCH v2 4/5] riscv: dts: thead: Add IO labels for the IO expansion on I2C1 Icenowy Zheng
2026-07-14 7:56 ` sashiko-bot
2026-07-16 20:52 ` Drew Fustini [this message]
2026-07-17 4:11 ` Icenowy Zheng
2026-07-14 7:45 ` [PATCH v2 5/5] riscv: dts: thead: Add remaining Lichee Pi 4A IO expansions Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=allEg/A+Gt/em0Hs@x1 \
--to=fustini@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=guoren@kernel.org \
--cc=i@leak.moe \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=uwu@icenowy.me \
--cc=wefu@redhat.com \
--cc=zhengxingda@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox