From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AAC742A179; Fri, 17 Jul 2026 15:03:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784300633; cv=none; b=tbjdAqkjkx24UunfBxD6GuuXj7JGe/ascGGfvZSyLDG+iFRgXJ+WJTmh0uQ5XC2w1DFPwTjBWGqDE99JDuBqkzX5lwDqxA+keLNwRDi1iQH7kJKERaojy/nRQz/iaC2uplCgx9spL7m1J8e7/YGQe4TdOfr4U2dMAWkzvIxEnms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784300633; c=relaxed/simple; bh=3Awj/mEyGq9TWE6CwNyBbCQP11JZYyMs3Nh7V5pd+xs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dQs3en2qLvL1CC0erNYRvDszLywF4n9nJ0HBFd2W1eeNA4KX2bGYiLmWb6QIyvk1FGscnRKdrlMZWeGl8ztJJ4rWRLyn97uw6r3e0NbDgJHao97Mddw9v5fng7qu7ze96oStcHX5XNsqv4R3wfoizDK97Pig1ZCOEk98+fRt27I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZaccoDxo; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZaccoDxo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D8801F000E9; Fri, 17 Jul 2026 15:03:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784300632; bh=yksjHE8eEsyu5iTXNXXdmShnpRuHBDVAl4ajHQZo3CA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=ZaccoDxoOH2lcgSvu8LXxFsftHKUMQrkC0nmExHOdwO5j8SdzihKbS4RobczbJ4JZ uvhEPXaHr5uaQtI+xDgID3j5Z3hMwMSu6CHIE+eqP5j9SZOrxR0vp36y79n7cr02fe 2Qr+8MsdMNhTPSMEa4LAZjuuPx2aN8bpCFfs42t+KQjuSM9KryVpc9IkxeqAHP6ww6 EmPRYPD8nn9N5i6F1MSRMBcZsMDvZeRuLrtBMJnlPp6sSPR+wZwXMfHvfMzfLJ+gFY 2YIg6dsjszqc+x/e98s+liB8gUlW4LmMCxXI1F0xOOW4+l2l6apPts9MowDGpizFCt YoQ/ScN7NGLfw== Received: from johan by xi.lan with local (Exim 4.99.4) (envelope-from ) id 1wkk6P-00000007cuh-3tow; Fri, 17 Jul 2026 17:03:49 +0200 Date: Fri, 17 Jul 2026 17:03:49 +0200 From: Johan Hovold To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Thuan Nguyen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , linux-renesas-soc@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 2/4] drm/bridge: display-connector: Fix I2C adapter resource leak Message-ID: References: <20260705213542.28987-1-laurent.pinchart+renesas@ideasonboard.com> <20260705213542.28987-3-laurent.pinchart+renesas@ideasonboard.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260705213542.28987-3-laurent.pinchart+renesas@ideasonboard.com> On Mon, Jul 06, 2026 at 12:35:40AM +0300, Laurent Pinchart wrote: > If the probe function returns an error after getting the I2C adapter for > DDC, the reference to the adapter is never released. Fix it by releasing > it in the bridge .destroy() handler. > > There is no need to test the ddc pointer with !IS_ERR(), as > of_get_i2c_adapter_by_node() returns NULL on error. I stumbled over this this morning as well and posted a fix here (which releases the adapter on driver unbind as is currently done): https://lore.kernel.org/lkml/20260717085716.1619275-1-johan@kernel.org/ > Fixes: 6de79dd3a920 ("drm/bridge: display-connector: add ddc-en gpio support") I believe this issue was first introduced by commit 2e2bf3a5584d ("drm/bridge: display-connector: add DP support") a few releases earlier. > Cc: stable@vger.kernel.org > Signed-off-by: Laurent Pinchart Reviewed-by: Johan Hovold Johan