devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: sun4i: dt: Add basic board support for LinkSprite pcDuino
@ 2014-01-11 15:54 Zoltan HERPAI
       [not found] ` <alpine.DEB.2.02.1401111509430.13932-35KbhngVGxv1KanxuVi64+yrfmlZI2zM@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Zoltan HERPAI @ 2014-01-11 15:54 UTC (permalink / raw)
  To: maxime.ripard; +Cc: hdegoede, linux-sunxi, linux-arm-kernel, devicetree

This patch will add a basic board support DT for the
LinkSprite pcDuino.

Signed-off-by: Zoltan HERPAI <wigyori@uid0.hu>
---
  arch/arm/boot/dts/Makefile              |    1 +
  arch/arm/boot/dts/sun4i-a10-pcduino.dts |   48 +++++++++++++++++++++++++++++++
  2 files changed, 49 insertions(+), 0 deletions(-)
  create mode 100644 arch/arm/boot/dts/sun4i-a10-pcduino.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index b663ed7..a2e3620 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -253,6 +253,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += \
  	sun4i-a10-cubieboard.dtb \
  	sun4i-a10-mini-xplus.dtb \
  	sun4i-a10-hackberry.dtb \
+	sun4i-a10-pcduino.dtb \
  	sun5i-a10s-olinuxino-micro.dtb \
  	sun5i-a13-olinuxino.dtb \
  	sun5i-a13-olinuxino-micro.dtb \
diff --git a/arch/arm/boot/dts/sun4i-a10-pcduino.dts b/arch/arm/boot/dts/sun4i-a10-pcduino.dts
new file mode 100644
index 0000000..752f002
--- /dev/null
+++ b/arch/arm/boot/dts/sun4i-a10-pcduino.dts
@@ -0,0 +1,48 @@
+/*
+ * Copyright 2014 Zoltan HERPAI
+ * Zoltan HERPAI <wigyori@uid0.hu>
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/dts-v1/;
+/include/ "sun4i-a10.dtsi"
+
+/ {
+	model = "LinkSprite pcDuino";
+	compatible = "pcduino,a10-pcduino", "allwinner,sun4i-a10";
+
+	soc@01c00000 {
+		emac: ethernet@01c0b000 {
+			pinctrl-names = "default";
+			pinctrl-0 = <&emac_pins_a>;
+			phy = <&phy1>;
+			status = "okay";
+		};
+
+		mdio@01c0b080 {
+			status = "okay";
+
+			phy1: ethernet-phy@1 {
+				reg = <1>;
+			};
+		};
+
+		uart0: serial@01c28000 {
+			pinctrl-names = "default";
+			pinctrl-0 = <&uart0_pins_a>;
+			status = "okay";
+		};
+
+		i2c0: i2c@01c2ac00 {
+			pinctrl-names = "default";
+			pinctrl-0 = <&i2c0_pins_a>;
+			status = "okay";
+		};
+	};
+};
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: sun4i: dt: Add basic board support for LinkSprite pcDuino
       [not found] ` <alpine.DEB.2.02.1401111509430.13932-35KbhngVGxv1KanxuVi64+yrfmlZI2zM@public.gmane.org>
@ 2014-01-13 10:07   ` Maxime Ripard
  2014-01-13 10:31     ` Zoltan HERPAI
  0 siblings, 1 reply; 3+ messages in thread
From: Maxime Ripard @ 2014-01-13 10:07 UTC (permalink / raw)
  To: Zoltan HERPAI
  Cc: hdegoede-H+wXaHxf7aLQT0dZR+AlfA,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 2114 bytes --]

Hi Zoltan,

On Sat, Jan 11, 2014 at 04:54:52PM +0100, Zoltan HERPAI wrote:
> This patch will add a basic board support DT for the
> LinkSprite pcDuino.
> 
> Signed-off-by: Zoltan HERPAI <wigyori-1V5s5g7wVVk@public.gmane.org>
> ---
>  arch/arm/boot/dts/Makefile              |    1 +
>  arch/arm/boot/dts/sun4i-a10-pcduino.dts |   48 +++++++++++++++++++++++++++++++
>  2 files changed, 49 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/boot/dts/sun4i-a10-pcduino.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index b663ed7..a2e3620 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -253,6 +253,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += \
>  	sun4i-a10-cubieboard.dtb \
>  	sun4i-a10-mini-xplus.dtb \
>  	sun4i-a10-hackberry.dtb \
> +	sun4i-a10-pcduino.dtb \
>  	sun5i-a10s-olinuxino-micro.dtb \
>  	sun5i-a13-olinuxino.dtb \
>  	sun5i-a13-olinuxino-micro.dtb \
> diff --git a/arch/arm/boot/dts/sun4i-a10-pcduino.dts b/arch/arm/boot/dts/sun4i-a10-pcduino.dts
> new file mode 100644
> index 0000000..752f002
> --- /dev/null
> +++ b/arch/arm/boot/dts/sun4i-a10-pcduino.dts
> @@ -0,0 +1,48 @@
> +/*
> + * Copyright 2014 Zoltan HERPAI
> + * Zoltan HERPAI <wigyori-1V5s5g7wVVk@public.gmane.org>
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */
> +
> +/dts-v1/;
> +/include/ "sun4i-a10.dtsi"
> +
> +/ {
> +	model = "LinkSprite pcDuino";
> +	compatible = "pcduino,a10-pcduino", "allwinner,sun4i-a10";

Is LinkSprite the retailer or the manufacturer?

If the former, it shouldn't appear in the model string, if the latter,
it should be the prefix in the compatible.

Otherwise, it looks very good, thanks!

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: sun4i: dt: Add basic board support for LinkSprite pcDuino
  2014-01-13 10:07   ` Maxime Ripard
@ 2014-01-13 10:31     ` Zoltan HERPAI
  0 siblings, 0 replies; 3+ messages in thread
From: Zoltan HERPAI @ 2014-01-13 10:31 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: hdegoede-H+wXaHxf7aLQT0dZR+AlfA,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA

Hi Maxime,

On Mon, 13 Jan 2014, Maxime Ripard wrote:

[...]
> Is LinkSprite the retailer or the manufacturer?
>
> If the former, it shouldn't appear in the model string, if the latter,
> it should be the prefix in the compatible.
>
> Otherwise, it looks very good, thanks!

LinkSprite is the manufacturer - I'll make a v2 soon, thanks!

Regards,
Zoltan Herpai

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-01-13 10:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-11 15:54 [PATCH] ARM: sun4i: dt: Add basic board support for LinkSprite pcDuino Zoltan HERPAI
     [not found] ` <alpine.DEB.2.02.1401111509430.13932-35KbhngVGxv1KanxuVi64+yrfmlZI2zM@public.gmane.org>
2014-01-13 10:07   ` Maxime Ripard
2014-01-13 10:31     ` Zoltan HERPAI

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).