From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: Re: [PATCH v2] coccinelle: Check for missing NULL terminators in of_device_id tables Date: Tue, 3 Jun 2014 20:14:19 +0200 (CEST) Message-ID: References: <1401213858-31950-1-git-send-email-sboyd@codeaurora.org> <538E09C1.30200@codeaurora.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <538E09C1.30200-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Boyd Cc: Julia Lawall , Michal Marek , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mitchel Humpherys , Gilles Muller , Nicolas Palix , Grant Likely , Rob Herring , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, 3 Jun 2014, Stephen Boyd wrote: > On 06/03/14 03:15, Julia Lawall wrote: > > Failure to terminate an of_device_id table can lead to confusing > > failures depending on where the compiler places the array. Add a > > check to make sure these tables are terminated. Thanks to Mitchel > > Humpherys for coming up with the pattern initially. > > > > Cc: Mitchel Humpherys > > Cc: Julia Lawall > > Cc: Gilles Muller > > Cc: Nicolas Palix > > Cc: Grant Likely > > Cc: Rob Herring > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > Signed-off-by: Stephen Boyd > > Acked-by: Grant Likely > > Signed-off-by: Julia Lawall > > > > --- > > > > v3: Removed unneeded rule bad_of_table. Placed * in context rule on the > > closing brace; putting it on the field caused all fields to be marked. > > > > > These seem like only minor changes. Why was my authorship removed? Probably because I don't know how to provide a new vesion of the patch properly. What should I have done? There were quite a lot of modifications. It seemed easier to just send a complete new version. julia -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html