Devicetree
 help / color / mirror / Atom feed
From: atull <atull@opensource.altera.com>
To: "Chen, Alvin" <alvin.chen@intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Ong, Boon Leong" <boon.leong.ong@intel.com>,
	"Kweh, Hock Leong" <hock.leong.kweh@intel.com>,
	Darren Hart <dvhart@linux.intel.com>,
	Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
	"Westerberg, Mika" <mika.westerberg@intel.com>,
	"Shevchenko, Andriy" <andriy.shevchenko@intel.com>,
	Arnd Bergmann <arnd@arndb.de>
Subject: RE: [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver
Date: Thu, 11 Sep 2014 10:40:58 -0500	[thread overview]
Message-ID: <alpine.DEB.2.02.1409111039210.19272@atx-linux-37> (raw)
In-Reply-To: <4656BEB6164FC34F8171C6538F1A595B2E98F982@SHSMSX101.ccr.corp.intel.com>

On Thu, 11 Sep 2014, Chen, Alvin wrote:

> > >
> > > Hi Alvin,
> > >
> > > I did a quick test and this looks like it works for me (with device tree).
> > > I had a couple of small fixes below.
> > It is very appreciated to help testing.

Sure.  Thanks for adding features to the driver!

> > 
> > 
> > > Alan
> > >
> > > >
> > > > -	port->bgc.gc.ngpio = ngpio;
> > > > -	port->bgc.gc.of_node = port_np;
> > > > +#ifdef CONFIG_OF_GPIO
> > > > +	port->bgc.gc.of_node = pp->node;
> > > > +#endif
> > >
> > > Please use 'if (IS_ENABLED(CONFIG_OF_GPIO)) as a conditional as you do
> > > elsewhere.
> > OK.
> > 
> Alan, I just do a quick test, here we can't use 'IS_ENABLED', it can't be compiled without OF_GPIO set.
> Because 'gc.of_node' is not defined without 'OF_GPIO'. You can refer the structure of 'gc'.
> 

That makes sense.

Thanks,
Alan

  reply	other threads:[~2014-09-11 15:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-09 18:07 [PATCH 0/4 v3] The Designware GPIO Supporting Weike Chen
2014-09-09 18:07 ` [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver Weike Chen
2014-09-09 17:05   ` Darren Hart
2014-09-10  0:34     ` Chen, Alvin
2014-09-10  3:26       ` Darren Hart
2014-09-10 10:32         ` Chen, Alvin
2014-09-10 19:11   ` atull
2014-09-11  0:32     ` Chen, Alvin
2014-09-11  0:46     ` Chen, Alvin
2014-09-11 15:40       ` atull [this message]
2014-09-11  7:59     ` Shevchenko, Andriy
     [not found]       ` <1410422381.7023.15.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-11 15:26         ` atull
2014-09-15  1:18           ` Chen, Alvin
2014-09-16  1:07             ` Chen, Alvin
2014-09-09 18:07 ` [PATCH 2/4 v3] GPIO: gpio-dwapb: Change readl&writel to dwapb_read&dwapb_write Weike Chen
2014-09-09 18:08 ` [PATCH 3/4 v3] GPIO: gpio-dwapb: Support Debounce Weike Chen
2014-09-09 18:08 ` [PATCH 4/4 v3] GPIO: gpio-dwapb: Suspend & Resume PM enabling Weike Chen
2014-09-11 16:40   ` atull
2014-09-12  2:27     ` Chen, Alvin
2014-09-12 15:46       ` atull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1409111039210.19272@atx-linux-37 \
    --to=atull@opensource.altera.com \
    --cc=alvin.chen@intel.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=arnd@arndb.de \
    --cc=boon.leong.ong@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dvhart@linux.intel.com \
    --cc=gnurou@gmail.com \
    --cc=grant.likely@linaro.org \
    --cc=hock.leong.kweh@intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@intel.com \
    --cc=robh+dt@kernel.org \
    --cc=sebastian@breakpoint.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox