From: atull <atull@opensource.altera.com>
To: Weike Chen <alvin.chen@intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Boon Leong Ong <boon.leong.ong@intel.com>,
Hock Leong Kweh <hock.leong.kweh@intel.com>,
Darren Hart <dvhart@linux.intel.com>,
Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
Mika Westerberg <mika.westerberg@intel.com>,
Andriy Shevchenko <andriy.shevchenko@intel.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/4 v4] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver
Date: Tue, 16 Sep 2014 09:22:43 -0500 [thread overview]
Message-ID: <alpine.DEB.2.02.1409160921020.4740@atx-linux-37> (raw)
In-Reply-To: <1410859335-11080-2-git-send-email-alvin.chen@intel.com>
On Tue, 16 Sep 2014, Weike Chen wrote:
One more:
> +
> + /*
> + * Only port A can provide interrupts in all configurations of
> + * the IP.
> + */
> + if (pp->idx == 0 &&
> + of_property_read_bool(port_np, "interrupt-controller")) {
> + pp->irq = irq_of_parse_and_map(port_np, 0);
> + if (!pp->irq) {
> + dev_warn(dev, "no irq for bank %s\n",
> + port_np->full_name);
> + }
> + } else {
> + pp->irq = 0;
> + }
The else clause is not needed since pp->irq == 0 already, right?
Alan
> +
> + pp->irq_shared = false;
> + pp->gpio_base = -1;
> + pp->name = port_np->full_name;
> + }
> +
> + return pdata;
> +}
next prev parent reply other threads:[~2014-09-16 14:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 9:22 [PATCH 0/4 v4] The Designware GPIO Supporting Weike Chen
2014-09-16 9:22 ` [PATCH 1/4 v4] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver Weike Chen
2014-09-16 14:22 ` atull [this message]
2014-09-17 7:09 ` Chen, Alvin
2014-09-16 9:22 ` [PATCH 2/4 v4] GPIO: gpio-dwapb: Change readl&writel to dwapb_read&dwapb_write Weike Chen
2014-09-16 9:22 ` [PATCH 3/4 v4] GPIO: gpio-dwapb: Support Debounce Weike Chen
2014-09-16 8:37 ` Andy Shevchenko
2014-09-17 6:47 ` Chen, Alvin
2014-09-16 9:22 ` [PATCH 4/4 v4] GPIO: gpio-dwapb: Suspend & Resume PM enabling Weike Chen
2014-09-16 7:24 ` Shevchenko, Andriy
[not found] ` <1410859335-11080-5-git-send-email-alvin.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-16 7:26 ` Andy Shevchenko
2014-09-17 6:46 ` Chen, Alvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1409160921020.4740@atx-linux-37 \
--to=atull@opensource.altera.com \
--cc=alvin.chen@intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=boon.leong.ong@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dvhart@linux.intel.com \
--cc=gnurou@gmail.com \
--cc=grant.likely@linaro.org \
--cc=hock.leong.kweh@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@intel.com \
--cc=robh+dt@kernel.org \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox