Re: [PATCH v9 5/7] staging: fpga manager core

[atull <atull@opensource.altera.com>]

On Fri, 17 Jul 2015, Randy Dunlap wrote:

> On 07/17/15 08:51, atull@opensource.altera.com wrote:
> > From: Alan Tull <atull@opensource.altera.com>
> > 
> > ---
> >  drivers/staging/Kconfig         |    2 +
> >  drivers/staging/Makefile        |    1 +
> >  drivers/staging/fpga/Kconfig    |   14 ++
> >  drivers/staging/fpga/Makefile   |    8 +
> >  drivers/staging/fpga/fpga-mgr.c |  373 +++++++++++++++++++++++++++++++++++++++
> >  include/linux/fpga/fpga-mgr.h   |  127 +++++++++++++
> >  6 files changed, 525 insertions(+)
> >  create mode 100644 drivers/staging/fpga/Kconfig
> >  create mode 100644 drivers/staging/fpga/Makefile
> >  create mode 100644 drivers/staging/fpga/fpga-mgr.c
> >  create mode 100644 include/linux/fpga/fpga-mgr.h
> 
> > diff --git a/drivers/staging/fpga/Kconfig b/drivers/staging/fpga/Kconfig
> > new file mode 100644
> > index 0000000..8254ca0
> > --- /dev/null
> > +++ b/drivers/staging/fpga/Kconfig
> > @@ -0,0 +1,14 @@
> > +#
> > +# FPGA framework configuration
> > +#
> > +
> > +menu "FPGA Configuration Support"
> > +
> > +config FPGA
> > +	bool "FPGA Configuration Framework"
> > +	help
> > +	  Say Y here if you want support for configuring FPGAs from the
> > +	  kernel.  The FPGA framework adds a FPGA manager class and FPGA
> > +	  manager drivers.
> > +
> > +endmenu
> 
> Is there some good reason why this is 'bool' instead of 'tristate'?
> I.e., why can't it be built as a loadable module?

Hi Randy,

The simple fpga bus probe function will need probe deferral added for it to
work with that if it gets probed before the fpga manager is loaded.  But I 
think it needed that anyway.  I'll work on it.

Thanks,
Alan


> 
> Thanks.
> 
> -- 
> ~Randy
>