From: atull <atull@opensource.altera.com>
To: Moritz Fischer <moritz.fischer@ettus.com>
Cc: Rob Herring <robh+dt@kernel.org>, Josh Cartwright <joshc@ni.com>,
Greg KH <gregkh@linuxfoundation.org>,
Michal Simek <monstr@monstr.eu>,
Michal Simek <michal.simek@xilinx.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Jonathan Corbet <corbet@lwn.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Devicetree List <devicetree@vger.kernel.org>,
linux-doc@vger.kernel.org,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Alan Tull <delicious.quinoa@gmail.com>,
"dinguyen@opensource.altera.com" <dinguyen@opensource.altera.com>
Subject: Re: [PATCH v15 5/6] fpga: fpga-area and fpga-bus: device tree control for FPGA
Date: Thu, 21 Jan 2016 11:23:44 -0600 [thread overview]
Message-ID: <alpine.DEB.2.02.1601211121430.8804@linuxheads99> (raw)
In-Reply-To: <CAAtXAHeNXyro3=TOoHehFQMTFdwWD5oBxS3H5cvxiuZx+Zvehw@mail.gmail.com>
On Thu, 21 Jan 2016, Moritz Fischer wrote:
> Hi Alan,
>
> minor nits inline:
>
> On Wed, Jan 20, 2016 at 8:24 PM, <atull@opensource.altera.com> wrote:
>
> > v15: Add altr,fpga-bus implementation
> > Change compatible string "fpga-area" -> "altr,fpga-area"
>
> Doesn't look that way down there. Or am I reading the code wrong?
Hi Moritz,
Yes, I left that out accidentally. But hopefully we won't have
pushback around this issue and I can leave it out permanently
and also change altr,fpga-bus to fpga-bus.
Alan
>
> > +static const struct of_device_id fpga_area_of_match[] = {
> > + { .compatible = "fpga-area", },
>
> I'm fine with keeping it as fpga-area, this isn't altera specific imho
>
> Cheers,
>
> Moritz
>
next prev parent reply other threads:[~2016-01-21 17:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 19:24 [PATCH v15 0/6] altera fpga area and fpga bus atull
2016-01-20 19:24 ` [PATCH v15 1/6] fpga: add bindings document for " atull
2016-01-21 15:00 ` Moritz Fischer
2016-01-21 17:21 ` atull
2016-01-21 20:33 ` Moritz Fischer
2016-01-25 16:53 ` Rob Herring
2016-01-27 20:24 ` atull
2016-01-27 21:15 ` Moritz Fischer
2016-01-20 19:24 ` [PATCH v15 2/6] add sysfs document for fpga bridge class atull
2016-01-21 12:17 ` Måns Rullgård
2016-01-21 12:20 ` Moritz Fischer
[not found] ` <1453317867-10422-3-git-send-email-atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2016-01-21 16:32 ` atull
2016-01-20 19:24 ` [PATCH v15 3/6] ARM: socfpga: add bindings document for fpga bridge drivers atull
2016-01-20 19:24 ` [PATCH v15 4/6] fpga: add fpga bridge framework atull
2016-01-20 19:24 ` [PATCH v15 5/6] fpga: fpga-area and fpga-bus: device tree control for FPGA atull
2016-01-21 14:44 ` Moritz Fischer
2016-01-21 17:23 ` atull [this message]
2016-01-22 11:01 ` Moritz Fischer
2016-01-22 16:37 ` atull
2016-01-23 0:07 ` Moritz Fischer
2016-01-25 16:17 ` Rob Herring
2016-01-27 18:59 ` atull
2016-01-20 19:24 ` [PATCH v15 6/6] ARM: socfpga: fpga bridge driver support atull
[not found] ` <1453317867-10422-1-git-send-email-atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2016-01-21 9:48 ` [PATCH v15 0/6] altera fpga area and fpga bus Moritz Fischer
2016-01-21 16:42 ` atull
2016-01-21 20:38 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1601211121430.8804@linuxheads99 \
--to=atull@opensource.altera.com \
--cc=corbet@lwn.net \
--cc=delicious.quinoa@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=joshc@ni.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=moritz.fischer@ettus.com \
--cc=pantelis.antoniou@konsulko.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).