From: atull <atull@opensource.altera.com>
To: Moritz Fischer <moritz.fischer@ettus.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Jon Masters <jcm@redhat.com>,
Michal Simek <michal.simek@xilinx.com>,
Jonathan Corbet <corbet@lwn.net>,
Cyril Chemparathy <cyril.chemparathy@xilinx.com>,
Matthew Gerlach <mgerlach@opensource.altera.com>,
Dinh Nguyen <dinguyen@opensource.altera.com>,
Devicetree List <devicetree@vger.kernel.org>,
linux-doc@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alan Tull <delicious.quinoa@gmail.com>
Subject: Re: [PATCH v20 02/10] doc: fpga-mgr: add fpga image info to api
Date: Tue, 18 Oct 2016 13:28:08 -0500 [thread overview]
Message-ID: <alpine.DEB.2.02.1610181323370.20737@linuxheads99> (raw)
In-Reply-To: <CAAtXAHcpwmW_7f2F9vk49hAHpOTs4rk9fFvLzn5zNdPZCy_O7A@mail.gmail.com>
On Mon, 17 Oct 2016, Moritz Fischer wrote:
> Hi Alan,
>
> couple of nits inline and some comments on ordering the patches ;-)
>
> On Mon, Oct 17, 2016 at 6:09 PM, Alan Tull <atull@opensource.altera.com> wrote:
> > This patch adds a minor change in the FPGA Mangager API
>
> s/Mangager/Manager/
Yup!
>
> > to hold information that is specific to an FPGA image
> > file. This change is expected to bring little, if any,
> > pain.
> >
> > An FPGA image file will have particulars that affect how the
> > image is programmed to the FPGA. One example is that
> > current 'flags' currently has one bit which shows whether the
> > FPGA image was built for full reconfiguration or partial
> > reconfiguration. Another example is timeout values for
> > enabling or disabling the bridges in the FPGA. As the
> > complexity of the FPGA design increases, the bridges in the
> > FPGA may take longer times to enable or disable.
>
> According for the current ordering bridges are not yet defined if we
> merge patches in this order?
> Not terrible imho, but I thought I'd point it out. Would swapping the
> order make sense?
Probably, yes.
>
> I also think [5/10] should be squashed together with this commit to
> make it an atomic change.
So far my bindings and code have gone in separately.
Bindings through Rob and code through Greg KH or Dinh.
>
> Apart from my comments above feel free to add my Acked-by
>
> Thanks for keeping this going,
>
> Moritz
>
Thanks for all the code reviews!
Alan
next prev parent reply other threads:[~2016-10-18 18:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 16:09 [PATCH v20 00/10] Device Tree support for FPGA Programming Alan Tull
2016-10-17 16:09 ` [PATCH v20 01/10] fpga: add bindings document for fpga region Alan Tull
2016-10-17 16:09 ` [PATCH v20 02/10] doc: fpga-mgr: add fpga image info to api Alan Tull
2016-10-17 21:00 ` Moritz Fischer
2016-10-18 18:28 ` atull [this message]
2016-10-17 16:09 ` [PATCH v20 03/10] add bindings document for altera freeze bridge Alan Tull
2016-10-18 16:26 ` Rob Herring
2016-10-18 18:34 ` atull
2016-10-17 16:09 ` [PATCH v20 04/10] add sysfs document for fpga bridge class Alan Tull
2016-10-17 16:09 ` [PATCH v20 05/10] fpga-mgr: add fpga image information struct Alan Tull
2016-10-17 16:09 ` [PATCH v20 06/10] fpga: add fpga bridge framework Alan Tull
[not found] ` <20161017160941.4205-7-atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2016-10-17 20:25 ` atull
[not found] ` <20161017160941.4205-1-atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2016-10-17 16:09 ` [PATCH v20 07/10] fpga: fpga-region: device tree control for FPGA Alan Tull
2016-10-17 16:09 ` [PATCH v20 08/10] ARM: socfpga: fpga bridge driver support Alan Tull
2016-10-17 16:09 ` [PATCH v20 09/10] fpga: add altera freeze bridge support Alan Tull
2016-10-17 16:09 ` [PATCH v20 10/10] fpga-manager: Add Socfpga Arria10 support Alan Tull
2016-10-18 21:01 ` Moritz Fischer
2016-10-19 15:49 ` atull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1610181323370.20737@linuxheads99 \
--to=atull@opensource.altera.com \
--cc=corbet@lwn.net \
--cc=cyril.chemparathy@xilinx.com \
--cc=delicious.quinoa@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgerlach@opensource.altera.com \
--cc=michal.simek@xilinx.com \
--cc=moritz.fischer@ettus.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox