From: Thomas Gleixner <tglx@linutronix.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
daniel.lezcano@linaro.org, wim@iguana.be, a.zummo@towertech.it,
linux-watchdog@vger.kernel.org, rtc-linux@googlegroups.com,
linux@roeck-us.net, kernel@stlinux.com
Subject: Re: [PATCH v2 02/12] clocksource: sti: Provide support for the ST LPC Clocksource IP
Date: Tue, 12 May 2015 17:55:24 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1505121751560.4225@nanos> (raw)
In-Reply-To: <1431435500-22899-3-git-send-email-lee.jones@linaro.org>
On Tue, 12 May 2015, Lee Jones wrote:
> +static void st_clksrc_reset(void)
__init
> +static int st_clksrc_setup_clk(struct device_node *np)
__init
> +static void __init st_clksrc_of_register(struct device_node *np)
> +{
> + int ret;
> + uint32_t mode;
> +
> + ret = of_property_read_u32(np, "st,lpc-mode", &mode);
> + if (ret) {
> + pr_err("clksrc-st-lpc: An LPC mode must be provided\n");
> + return;
> + }
> +
> + /* LPC can either run as a Clocksource or in RTC or WDT mode */
> + if (mode != ST_LPC_MODE_CLKSRC)
> + return;
> +
> + ddata.base = of_iomap(np, 0);
> + if (!ddata.base) {
> + pr_err("clksrc-st-lpc: Unable to map iomem\n");
> + return;
> + }
> +
> + if (st_clksrc_setup_clk(np)) {
> + iounmap(ddata.base);
> + return;
> + }
> +
> + if (st_clksrc_init()) {
Keeps the clock enabled.
> + iounmap(ddata.base);
> + return;
Thanks,
tglx
next prev parent reply other threads:[~2015-05-12 15:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 12:58 [PATCH v2 00/12] mfd: Add support for Clocksource to LPC set Lee Jones
2015-05-12 12:58 ` [PATCH v2 03/12] clocksource: sti: Provide 'use timer as sched clock' capability Lee Jones
2015-05-27 12:40 ` Daniel Lezcano
[not found] ` <1431435500-22899-1-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-05-12 12:58 ` [PATCH v2 01/12] mfd: dt-bindings: Provide human readable define for Clocksource mode Lee Jones
2015-05-12 12:58 ` [PATCH v2 02/12] clocksource: sti: Provide support for the ST LPC Clocksource IP Lee Jones
2015-05-12 15:55 ` Thomas Gleixner [this message]
2015-05-26 12:39 ` [PATCH v2.1 " Lee Jones
2015-05-27 12:38 ` Daniel Lezcano
2015-05-12 12:58 ` [PATCH v2 04/12] clocksource: bindings: Provide bindings for ST's LPC Clocksource device Lee Jones
2015-05-12 12:58 ` [PATCH v2 05/12] watchdog: st_wdt: Update IP layout information to include Clocksource Lee Jones
2015-05-12 12:58 ` [PATCH v2 09/12] MAINTAINERS: Add the LPC Clocksource to STi maintained driver list Lee Jones
2015-06-01 7:38 ` [PATCH v2 00/12] mfd: Add support for Clocksource to LPC set Lee Jones
2015-05-12 12:58 ` [PATCH v2 06/12] watchdog: bindings: Supply knowledge of a third supported device - clocksource Lee Jones
2015-05-12 12:58 ` [PATCH v2 07/12] rtc: st: Update IP layout information to include Clocksource Lee Jones
2015-05-12 12:58 ` [PATCH v2 08/12] rtc: bindings: Supply knowledge of a third supported device - clocksource Lee Jones
2015-05-12 12:58 ` [PATCH v2 10/12] ARM: STi: DT: STih407: Switch LPC mode from RTC to Clocksource Lee Jones
2015-05-12 12:58 ` [PATCH v2 11/12] ARM: STi: Enable LPC Clocksource Lee Jones
2015-05-12 12:58 ` [PATCH v2 12/12] ARM: STi: Update platform level menuconfig 'help' Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1505121751560.4225@nanos \
--to=tglx@linutronix.de \
--cc=a.zummo@towertech.it \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rtc-linux@googlegroups.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox