From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH v2 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2. Date: Sun, 26 Jul 2015 11:52:52 +0200 (CEST) Message-ID: References: <1436837718-956-1-git-send-email-eric@anholt.net> <1436837718-956-5-git-send-email-eric@anholt.net> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <1436837718-956-5-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Eric Anholt Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Stephen Warren , Lee Jones , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jason Cooper , Andrea Merello List-Id: devicetree@vger.kernel.org On Mon, 13 Jul 2015, Eric Anholt wrote: > +static void > +bcm2836_arm_irqchip_smp_init(void) > +{ > +#ifdef CONFIG_SMP > + int i; > + > + /* unmask IPIs */ > + for_each_possible_cpu(i) { > + bcm2836_arm_irqchip_unmask_per_cpu_irq( > + LOCAL_MAILBOX_INT_CONTROL0, 0, i); Do you really want to enable these interrupts on all possible cpus? Why so? Shouldn't that be done at the point where a hotplugged CPU is starting ? Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html