From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH] irqchip: bcm2836: Use a CPU notifier enable IPIs. Date: Tue, 4 Aug 2015 09:14:34 +0200 (CEST) Message-ID: References: <55B67C81.1010900@gmail.com> <1438027789-1637-1-git-send-email-eric@anholt.net> <87fv40lzxe.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <87fv40lzxe.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Eric Anholt Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Stephen Warren , Lee Jones , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jason Cooper List-Id: devicetree@vger.kernel.org On Mon, 3 Aug 2015, Eric Anholt wrote: > Thomas Gleixner writes: > > > On Mon, 27 Jul 2015, Eric Anholt wrote: > >> +/* Unmasks the IPI on the CPU wen it's first brought online. */ > > > > when > > > >> +static int bcm2836_arm_irqchip_cpu_notify(struct notifier_block *nfb, > >> + unsigned long action, void *hcpu) > >> +{ > >> + unsigned int cpu = (unsigned long)hcpu; > >> + unsigned int int_reg = LOCAL_MAILBOX_INT_CONTROL0; > >> + unsigned int mailbox = 0; > >> + > >> + if (action == CPU_STARTING || action == CPU_STARTING_FROZEN) > >> + bcm2836_arm_irqchip_unmask_per_cpu_irq(int_reg, mailbox, cpu); > > > > Shouldn't you mask the irq on CPU_DYING? > > I was just following what other drivers were doing. Is CPU_DYING the > only thing that needs masking? CPPU_DYING is the counterpart of CPU_STARTING. It's called from the CPU which goes down. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html