Devicetree
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Rob Herring <robh+dt@kernel.org>
Cc: Brian Starkey <brian.starkey@arm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Frank Rowand <frowand.list@gmail.com>,
	Grant Likely <grant.likely@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] genirq: fix trigger flags check for shared irqs
Date: Thu, 28 Jan 2016 21:06:20 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.11.1601282105150.3886@nanos> (raw)
In-Reply-To: <CAL_JsqLTFu18a-Mj_XPZBpcFkD+R-uiK70yLnCT27np2YK6_ag@mail.gmail.com>

On Thu, 28 Jan 2016, Rob Herring wrote:
> On Thu, Jan 28, 2016 at 5:49 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > I've cc'ed the author and the device tree folks. Perhaps are they able to
> > explain what this commit tries to 'fix'.
> 
> It's certainly not clear what driver was being fixed. I think the
> intention was to provide the trigger flags from the DT to drivers in a
> standard, non-DT specific way. The implementation of it certainly
> seems convoluted. The usecase I can think of is drivers may need the
> trigger information for cases where the device can support different
> trigger modes/polarity. The DT says which trigger mode to use and the
> device and irqchip need to be programmed to match. IIRC, SMSC ethernet
> chips frequently used on ARM boards do this.

I can see that the driver wants this information, but why would one feed that
back into request_irq() when the interrupt was already configured by DT.

Still confused.

Thanks,

	tglx

  reply	other threads:[~2016-01-28 20:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <96c068ece0f5d01fc85bdbd9e0798f68180eebb8.1453204950.git.brian.starkey@arm.com>
     [not found] ` <alpine.DEB.2.11.1601262142450.3886@nanos>
     [not found]   ` <20160128095955.GA12884@e106950-lin.cambridge.arm.com>
     [not found]     ` <alpine.DEB.2.11.1601281116310.3886@nanos>
     [not found]       ` <20160128111041.GB12884@e106950-lin.cambridge.arm.com>
2016-01-28 11:49         ` [PATCH] genirq: fix trigger flags check for shared irqs Thomas Gleixner
2016-01-28 12:22           ` Brian Starkey
     [not found]             ` <20160128122212.GC12884-XkuvqYGHIzfZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2016-01-28 13:37               ` Thomas Gleixner
2016-02-08 11:02                 ` Brian Starkey
2016-01-28 15:58           ` Rob Herring
2016-01-28 20:06             ` Thomas Gleixner [this message]
2016-01-29  4:17               ` Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1601282105150.3886@nanos \
    --to=tglx@linutronix.de \
    --cc=brian.starkey@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=grant.likely@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox