From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH 07/15] irqdomain: Don't set type when mapping an IRQ Date: Thu, 17 Mar 2016 15:55:18 +0100 (CET) Message-ID: References: <1458224359-32665-1-git-send-email-jonathanh@nvidia.com> <1458224359-32665-8-git-send-email-jonathanh@nvidia.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <1458224359-32665-8-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jon Hunter Cc: Jason Cooper , Marc Zyngier , =?ISO-8859-15?Q?Beno=EEt_Cousson?= , Tony Lindgren , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Stephen Warren , Thierry Reding , Kevin Hilman , Geert Uytterhoeven , Grygorii Strashko , Lars-Peter Clausen , Linus Walleij , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, 17 Mar 2016, Jon Hunter wrote: > --- a/kernel/irq/manage.c > +++ b/kernel/irq/manage.c > @@ -1117,6 +1117,13 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) > new->irq = irq; > > /* > + * If the trigger type is not specified by the caller, > + * then use the default for this interrupt. > + */ > + if (!(new->flags & IRQF_TRIGGER_MASK)) > + new->flags |= irqd_get_trigger_type(&desc->irq_data); > + This change is independent of the irqdomain part and should be in a seperate patch because it affects all callers. Thanks, tglx