From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support Date: Tue, 20 Sep 2016 11:51:27 +0200 (CEST) Message-ID: References: <1473432124-6784-1-git-send-email-alexandre.torgue@st.com> <1473432124-6784-3-git-send-email-alexandre.torgue@st.com> <6941f61d-0b33-4108-0135-b11887cd0488@st.com> <39c4ceee-7e05-ebfd-2ea0-3c4e1c4ea619@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <39c4ceee-7e05-ebfd-2ea0-3c4e1c4ea619@st.com> Sender: linux-kernel-owner@vger.kernel.org To: Alexandre Torgue Cc: Mark Rutland , devicetree@vger.kernel.org, Daniel Thompson , Jason Cooper , arnd@arndb.de, Marc Zyngier , bruherrera@gmail.com, Linus Walleij , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Rob Herring , Maxime Coquelin , lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Tue, 20 Sep 2016, Alexandre Torgue wrote: > > On 09/14/2016 03:34 PM, Thomas Gleixner wrote: > > > Well, you just used some function in some context which is not > > > relevant to > > > the normal operation. So adding that mask() is just paranoia for no > > > value. > > > A gentle reminder ping... > If ".free" callback is not relevant then I 'll remove it from exti domain. I was not talking about the .free callback in general. I was talking about the masking. But yes, if the thing is otherwise a NOOP, then you can spare it completely. Thanks, tglx