From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH v4 8/8] iio: envelope-detector: ADC driver based on a DAC and a comparator Date: Wed, 9 Nov 2016 16:06:29 +0100 (CET) Message-ID: References: <1478606339-31253-1-git-send-email-peda@axentia.se> <1478606339-31253-9-git-send-email-peda@axentia.se> <1c104a31-6c66-9537-9b90-ede58c8e1a92@axentia.se> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Peter Rosin Cc: linux-kernel@vger.kernel.org, Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Mark Rutland , Daniel Baluta , Slawomir Stepien , linux-iio@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On Wed, 9 Nov 2016, Peter Rosin wrote: > On 2016-11-08 22:47, Thomas Gleixner wrote: > > I don't think you need extra race handling with that, but I might be wrong > > as usual. > > There's obviously no way to determine which of the timeout or the > interrupt that happens first without some race handling, so I don't > know what you mean? If the timeout happens first, there is also a > need to handle late hits from the irq that might come in during the > preparation for the next step in the binary search. It gets messy > quickly compared to the simplicity of the current implementation. Gah, forgot about that timeout thingy. Fair enough. Feel free to add an Acked-by: Thomas Gleixner Thanks, tglx