From: Thomas Gleixner <tglx@linutronix.de>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
mcoquelin.stm32@gmail.com, alexandre.torgue@st.com,
daniel.lezcano@linaro.org, ludovic.barre@st.com,
julien.thierry@arm.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/5] clocksource: stm32: convert driver to timer_of
Date: Wed, 18 Oct 2017 20:31:27 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1710182028080.2477@nanos> (raw)
In-Reply-To: <1508331506-23782-3-git-send-email-benjamin.gaignard@linaro.org>
On Wed, 18 Oct 2017, Benjamin Gaignard wrote:
> Convert driver to use timer_of helpers. This allow to remove
> custom proprietary structure.
>
> Increase min delta value because if it is too small it could
> generate too much interrupts and the system will not be able
> to catch them all.
This does two completely independent changes at once. What the heck has
increasing min delta to do with converting it to timer_of() helpers?
Nothing at all. So please split this into two distinct patches. Each doing
ONE thing.
See Documentation/process/submitting-patches.rst:
3) Separate your changes
------------------------
Separate each **logical change** into a separate patch.
Reading, understanding and complying with that document is not optional.
Thanks,
tglx
next prev parent reply other threads:[~2017-10-18 18:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 12:58 [PATCH v6 0/5] stm32 clocksource driver rework Benjamin Gaignard
2017-10-18 12:58 ` [PATCH v6 1/5] timer: add timer_of_deinit function Benjamin Gaignard
[not found] ` <1508331506-23782-1-git-send-email-benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-10-18 12:58 ` [PATCH v6 2/5] clocksource: stm32: convert driver to timer_of Benjamin Gaignard
2017-10-18 18:31 ` Thomas Gleixner [this message]
2017-10-18 19:32 ` Benjamin Gaignard
[not found] ` <CA+M3ks4Eg2-S8yDZuMd-jqZ6g2efvveU_WwQEh0rPZW0fGDt3w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-19 9:07 ` Daniel Lezcano
2017-10-18 12:58 ` [PATCH v6 5/5] arm: dts: stm32: remove useless clocksource nodes Benjamin Gaignard
2017-10-18 13:21 ` Rob Herring
[not found] ` <CABGGisx1mrf8xSWAXSm9sevE16HgCT72RhcpH6J44ECQnCd3Jw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-18 13:38 ` Benjamin Gaignard
2017-10-18 12:58 ` [PATCH v6 3/5] clocksource: stm32: only use 32 bits timers Benjamin Gaignard
2017-10-18 18:35 ` Thomas Gleixner
2017-10-18 12:58 ` [PATCH v6 4/5] clocksource: stm32: add clocksource support Benjamin Gaignard
[not found] ` <1508331506-23782-5-git-send-email-benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-10-18 18:59 ` Thomas Gleixner
2017-10-19 8:06 ` Benjamin Gaignard
[not found] ` <CA+M3ks5K6+XnK1KDuSwAx1DF=jSJuWuGbvn64cWXrGnOTOPcCQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-19 8:18 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1710182028080.2477@nanos \
--to=tglx@linutronix.de \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=julien.thierry@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ludovic.barre@st.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox