From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: [PATCH] drivers/fsi: sbefifo: fix call_kern.cocci warnings Date: Tue, 21 Nov 2017 07:12:11 +0100 (CET) Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-path: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, bradleyb-r5pk2Da7Bxt8sGd51Jp2sdBPR1lH4CV8@public.gmane.org, cbostic-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org, eajames-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, "Edward A. James" , kbuild-all-JC7UmRfGjtg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Function sbefifo_enq_xfr called inside lock from sbefifo_write_common but uses GFP_KERNEL. Change to GFP_ATOMIC. Generated by: scripts/coccinelle/locks/call_kern.cocci Fixes: 0f8664fbfc9f ("drivers/fsi: sbefifo: Add miscdevice") CC: Edward A. James Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- Semantic patch information: The proposed change of converting the GFP_KERNEL is not necessarily the correct one. It may be desired to unlock the lock, or to not call the function under the lock in the first place. fsi-sbefifo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/fsi/fsi-sbefifo.c +++ b/drivers/fsi/fsi-sbefifo.c @@ -266,7 +266,7 @@ static struct sbefifo_xfr *sbefifo_enq_x if (READ_ONCE(sbefifo->rc)) return ERR_PTR(sbefifo->rc); - xfr = kzalloc(sizeof(*xfr), GFP_KERNEL); + xfr = kzalloc(sizeof(*xfr), GFP_ATOMIC); if (!xfr) return ERR_PTR(-ENOMEM); -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html