From: Julia Lawall <julia.lawall@lip6.fr>
To: jassisinghbrar@gmail.com
Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, vkoul@kernel.org,
robh+dt@kernel.org, masami.hiramatsu@linaro.org,
orito.takao@socionext.com,
Jassi Brar <jaswinder.singh@linaro.org>,
kbuild-all@01.org
Subject: [PATCH] dmaengine: milbeaut-hdmac: fix returnvar.cocci warnings
Date: Tue, 10 Sep 2019 12:02:04 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1909101200570.4379@hadrien> (raw)
From: kbuild test robot <lkp@intel.com>
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Fixes: 7cff81f3886d ("dmaengine: milbeaut-hdmac: Add HDMAC driver for Milbeaut platforms")
CC: Jassi Brar <jaswinder.singh@linaro.org>
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---
url: https://github.com/0day-ci/linux/commits/jassisinghbrar-gmail-com/Add-support-for-AHB-DMA-controller-on-Milbeaut-series/20190910-142047
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago
Please take the patch only if it's a positive warning. Thanks!
milbeaut-hdmac.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--- a/drivers/dma/milbeaut-hdmac.c
+++ b/drivers/dma/milbeaut-hdmac.c
@@ -171,7 +171,6 @@ static irqreturn_t milbeaut_hdmac_interr
{
struct milbeaut_hdmac_chan *mc = dev_id;
struct milbeaut_hdmac_desc *md;
- irqreturn_t ret = IRQ_HANDLED;
u32 val;
spin_lock(&mc->vc.lock);
@@ -201,7 +200,7 @@ static irqreturn_t milbeaut_hdmac_interr
out:
spin_unlock(&mc->vc.lock);
- return ret;
+ return IRQ_HANDLED;
}
static void milbeaut_hdmac_free_chan_resources(struct dma_chan *chan)
@@ -289,7 +288,6 @@ static int milbeaut_hdmac_terminate_all(
struct virt_dma_chan *vc = to_virt_chan(chan);
struct milbeaut_hdmac_chan *mc = to_milbeaut_hdmac_chan(vc);
unsigned long flags;
- int ret = 0;
u32 val;
LIST_HEAD(head);
@@ -311,7 +309,7 @@ static int milbeaut_hdmac_terminate_all(
vchan_dma_desc_free_list(vc, &head);
- return ret;
+ return 0;
}
static void milbeaut_hdmac_synchronize(struct dma_chan *chan)
reply other threads:[~2019-09-10 10:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1909101200570.4379@hadrien \
--to=julia.lawall@lip6.fr \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=jaswinder.singh@linaro.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu@linaro.org \
--cc=orito.takao@socionext.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox