From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADE2EC433DF for ; Fri, 22 May 2020 12:59:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81157206D5 for ; Fri, 22 May 2020 12:59:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729789AbgEVM72 (ORCPT ); Fri, 22 May 2020 08:59:28 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:27565 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729792AbgEVM7Z (ORCPT ); Fri, 22 May 2020 08:59:25 -0400 X-IronPort-AV: E=Sophos;i="5.73,421,1583190000"; d="scan'208";a="450910885" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2020 14:59:22 +0200 Date: Fri, 22 May 2020 14:59:22 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: kbuild-all@lists.01.org, "Andrew-sh.Cheng" , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Rob Herring , Mark Rutland , Matthias Brugger , "Rafael J . Wysocki" , Viresh Kumar , Nishanth Menon , Stephen Boyd , Liam Girdwood , Mark Brown , devicetree@vger.kernel.org, "Andrew-sh . Cheng" , srv_heupstream@mediatek.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Saravana Kannan , linux-mediatek@lists.infradead.org, Sibi Sankar , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] PM / devfreq: fix odd_ptr_err.cocci warnings In-Reply-To: <20200521160908.GA88022@052716d1a29e> Message-ID: References: <202005220024.mccUgEgn%lkp@intel.com> <20200521160908.GA88022@052716d1a29e> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello, This provides a patch, but it doesn't look like the right one. It looks like the if test should be testing opp_table, julia On Fri, 22 May 2020, kbuild test robot wrote: > From: kbuild test robot > > drivers/devfreq/governor_passive.c:336:7-13: inconsistent IS_ERR and PTR_ERR on line 337. > > PTR_ERR should access the value just tested by IS_ERR > > Semantic patch information: > There can be false positives in the patch case, where it is the call to > IS_ERR that is wrong. > > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci > > CC: Saravana Kannan > Signed-off-by: kbuild test robot > --- > > url: https://github.com/0day-ci/linux/commits/Andrew-sh-Cheng/Add-cpufreq-and-cci-devfreq-for-mt8183-and-SVS-support/20200520-222709 > base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next > :::::: branch date: 26 hours ago > :::::: commit date: 26 hours ago > > Please take the patch only if it's a positive warning. Thanks! > > governor_passive.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/devfreq/governor_passive.c > +++ b/drivers/devfreq/governor_passive.c > @@ -334,7 +334,7 @@ static int cpufreq_passive_register(stru > > opp_table = dev_pm_opp_get_opp_table(cpu_dev); > if (IS_ERR(devfreq->opp_table)) { > - ret = PTR_ERR(opp_table); > + ret = PTR_ERR(devfreq->opp_table); > goto out; > } > >