From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH 2/2] x86: of: define irq functions to allow drivers/of/* to build on x86 Date: Tue, 21 Sep 2010 18:27:23 +0200 (CEST) Message-ID: References: <20100910060151.6613e9c3@debxo> <20100910172538.GC11284@angua.secretlab.ca> <20100910181458.GA7243@elte.hu> <20100910182135.GG11284@angua.secretlab.ca> <20100920190604.5a2118da@debxo> <20100921091136.45f5f7fa@debxo> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100921091136.45f5f7fa@debxo> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Andres Salomon Cc: Mitch Bradley , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, Ingo Molnar List-Id: devicetree@vger.kernel.org On Tue, 21 Sep 2010, Andres Salomon wrote: > On Tue, 21 Sep 2010 11:45:37 +0200 (CEST) > Thomas Gleixner wrote: > > > > Any additional comments (ACKs, NACKs, etc) on the patches? If I > > > need to rework it (or them), I can certainly make the patch > > > description longer. > > > > Fine with me, but you could make the "mapping" function an inline as > > well. While at it, some sensible changelog would be helpful :) > > > > Thanks, > > > > tglx > > Hm, inlining it would require some additional x86 #ifdefs in > include/linux/of_irq.h (where the mapping function is declared). You'd > prefer that? Urgh, no. tglx