From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Pitre Subject: Re: [PULL REQUEST v2] ARM: kirkwood: fdt: convert kirkwood init funcs to fdt Date: Mon, 5 Mar 2012 15:43:42 -0500 (EST) Message-ID: References: <20120305191546.GK5050@titan.lakedaemon.net> <201203052016.26949.arnd@arndb.de> <20120305202941.GN5050@titan.lakedaemon.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120305202941.GN5050-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Jason Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, 5 Mar 2012, Jason wrote: > On Mon, Mar 05, 2012 at 08:16:26PM +0000, Arnd Bergmann wrote: > > On Monday 05 March 2012, Jason wrote: > > > > > > > > The clock frequency part being hardcoded to 200000 in the common .dtsi > > > > file looks wrong. The clock may differ, and it used to (and should) be > > > > probed at run time, please see kirkwood_find_tclk(). > > > > > > So, should I EXPORT_SYMBOL_GPL(kirkwood_find_tclk); and have each driver > > > call it? > > > > If the drivers want to use it, I think it has to be orion_find_tclk for > > drivers that are shared between multiple plat-orion platforms. > > That's pretty much all of them :-) > > I'll rename it and move it to plat-orion/common.c. This'll be fun. No no... This is not a function which is generic at all. The _result_ i.e. core clock frequency value is a generic thing, not the method to determine it. Nicolas