From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Robert P. J. Day" Subject: Re: [PATCH v2 2/6] libfdt: Add iterator over properties Date: Mon, 11 Jul 2016 18:57:46 -0700 (PDT) Message-ID: References: <20160711195623.12840-1-maxime.ripard@free-electrons.com> <20160711195623.12840-3-maxime.ripard@free-electrons.com> <20160712015335.GO16355@voom.fritz.box> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20160712015335.GO16355-RXTfZT5YzpxwFLYp8hBm2A@public.gmane.org> Sender: devicetree-compiler-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Gibson Cc: Maxime Ripard , Pantelis Antoniou , Simon Glass , Boris Brezillon , Alexander Kaplan , Thomas Petazzoni , devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, =?ISO-8859-15?Q?Antoine_T=E9nart?= , Stefan Agner , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, 12 Jul 2016, David Gibson wrote: > On Mon, Jul 11, 2016 at 09:56:19PM +0200, Maxime Ripard wrote: > > +/** > > + * fdt_for_each_property - iterate over all properties of a node > > + * @property_offset: property offset (int) > > + * @fdt: FDT blob (const void *) > > + * @node: node offset (int) > > + * > > + * This is actually a wrapper around a for loop and would be used like so: > > + * > > + * fdt_for_each_property(fdt, node, property) { > > Again, parameter order is out of date. also, when did kerneldoc content start specifying data types in the comment? (int, const void*, ...). i don't think that's standard. rday -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ========================================================================