From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Osmialowski Subject: Re: [PATCH v2 4/9] arm: twr-k70f120m: timer driver for Kinetis SoC Date: Wed, 1 Jul 2015 10:42:07 +0200 (CEST) Message-ID: References: <1435667250-28299-1-git-send-email-pawelo@king.net.pl> <1435667250-28299-5-git-send-email-pawelo@king.net.pl> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thomas Gleixner Cc: Paul Osmialowski , Greg Kroah-Hartman , Ian Campbell , Jiri Slaby , Kumar Gala , Linus Walleij , Mark Rutland , Michael Turquette , Pawel Moll , Rob Herring , Russell King , Stephen Boyd , Vinod Koul , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Arnd Bergmann , Geert Uytterhoeven , Nicolas Pitre , Paul Bolle Uwe Kleine-Koenig List-Id: devicetree@vger.kernel.org Hi Thomas, On Wed, 1 Jul 2015, Thomas Gleixner wrote: >> + clockevents_register_device( >> + &kinetis_clockevent_tmrs[chan].evtdev); >> + >> + kinetis_pit_init(&kinetis_clockevent_tmrs[chan], >> + (rate / HZ) - 1); >> + kinetis_pit_enable(&kinetis_clockevent_tmrs[chan], 1); > > No point doing this. The core code has invoked the set_periodic call > back via clockevents_register_device() already. > As I removed this kinetis_pit_enable() line, the timer did not start, therefore the system became unusable. What could be possible reason for that? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html