Re: [PATCH v2 4/9] arm: twr-k70f120m: timer driver for Kinetis SoC

Rob Herring
2015-07-05T14:39:26Z

On Tue, Jun 30, 2015 at 3:43 PM, Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> wrote:
> On Tuesday 30 June 2015 14:27:25 Paul Osmialowski wrote:
>

>> / {
>> + aliases {
>> + pit0 = &pit0;
>> + pit1 = &pit1;
>> + pit2 = &pit2;
>> + pit3 = &pit3;
>> + };
>> +
>> soc {
>> + pit@40037000 {
>> + compatible = "fsl,kinetis-pit-timer";
>> + reg = <0x40037000 0x100>;
>> + clocks = <&mcg_pclk_gate 5 23>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges;
>> +
>> + pit0: timer@40037100 {
>> + reg = <0x40037100 0x10>;
>> + interrupts = <68>;
>> + status = "disabled";
>> + };
>
> I don't think it's necessary to have both an alias
> and a label here. What do you use the alias for?

Yes, don't use aliases. If you really need a specific timer to be used
then there must be some feature it has or doesn't have (e.g. always
on, output compare pin, specific clock, etc.) Put those those
properties in DT if that is the case. See OMAP timers for a complex
example of this.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html